lib: use bracket notation instead of startsWith/endsWith for single char#61500
Open
kimtaejin3 wants to merge 1 commit intonodejs:mainfrom
Open
lib: use bracket notation instead of startsWith/endsWith for single char#61500kimtaejin3 wants to merge 1 commit intonodejs:mainfrom
startsWith/endsWith for single char#61500kimtaejin3 wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61500 +/- ##
==========================================
- Coverage 89.82% 89.78% -0.04%
==========================================
Files 667 672 +5
Lines 203693 203907 +214
Branches 39163 39199 +36
==========================================
+ Hits 182963 183078 +115
- Misses 13061 13162 +101
+ Partials 7669 7667 -2
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Jan 24, 2026
ljharb
approved these changes
Jan 24, 2026
lpinca
approved these changes
Jan 24, 2026
bjohansebas
approved these changes
Jan 24, 2026
startsWith/endsWith for single char
anonrig
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids potential prototype pollution and improves performance by replacing method calls with
direct property access.