buffer: optimize buffer.concat performance#61721
Open
mertcanaltin wants to merge 7 commits intonodejs:mainfrom
Open
buffer: optimize buffer.concat performance#61721mertcanaltin wants to merge 7 commits intonodejs:mainfrom
mertcanaltin wants to merge 7 commits intonodejs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61721 +/- ##
==========================================
+ Coverage 89.73% 89.74% +0.01%
==========================================
Files 675 675
Lines 204502 204673 +171
Branches 39304 39329 +25
==========================================
+ Hits 183502 183684 +182
+ Misses 13283 13281 -2
+ Partials 7717 7708 -9
🚀 New features to boost your workflow:
|
ChALkeR
reviewed
Feb 7, 2026
Member
ChALkeR
left a comment
There was a problem hiding this comment.
See #60399 (comment)
Shouldn't _copyActual be just using TypedArrayPrototypeSet since #60399?
cc @gurgunday
ChALkeR
reviewed
Feb 7, 2026
benjamingr
reviewed
Feb 7, 2026
gurgunday
reviewed
Feb 7, 2026
Member
Author
|
I updated bench result: #61721 (comment) |
Renegade334
reviewed
Feb 7, 2026
Renegade334
approved these changes
Feb 10, 2026
Renegade334
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the _copyActual indirection in the copy loop and called TypedArrayPrototypeSet directly.
Split auto-length and explicit-length paths so the auto-length copy loop is branch free. Replaced Buffer.allocUnsafe with allocate to skip redundant validation.
benchmark results: