crypto: always return certificate serial numbers as uppercase#61752
Closed
addaleax wants to merge 1 commit intonodejs:mainfrom
Closed
crypto: always return certificate serial numbers as uppercase#61752addaleax wants to merge 1 commit intonodejs:mainfrom
addaleax wants to merge 1 commit intonodejs:mainfrom
Conversation
This hides a discrepancy between OpenSSL and BoringSSL, as the latter returns lowercase hex values. Refs: nodejs#61459 (comment)
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
codebytere
approved these changes
Feb 9, 2026
cjihrig
approved these changes
Feb 9, 2026
pimterry
approved these changes
Feb 9, 2026
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61752 +/- ##
==========================================
- Coverage 89.74% 89.73% -0.02%
==========================================
Files 675 675
Lines 204601 204601
Branches 39317 39314 -3
==========================================
- Hits 183625 183601 -24
- Misses 13240 13284 +44
+ Partials 7736 7716 -20
🚀 New features to boost your workflow:
|
|
Nice |
Collaborator
Collaborator
tniessen
reviewed
Feb 9, 2026
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
I believe that the difference in behavior is due to BN_bn2hex, which ncrypto wraps in BignumPointer::toHex(). Maybe we should just wrap that call when Node.js is linked against BoringSSL?
Member
Author
|
@tniessen Yeah, I considered that too, but a) I didn't want to do this while the discussion in #61613 is alive and well and b) this is the only site where we expose this to users, and it's not obvious to me that we always care whether the call returns uppercase or lowercase hex? But I'm not feeling particularly strongly about this, and I'm happy to make that change there as well (if you feel confident about the repo in which that should happen 😅 ) |
lpinca
approved these changes
Feb 10, 2026
Collaborator
addaleax
added
the
commit-queue
addaleax
added a commit
that referenced
this pull request
Feb 12, 2026
This hides a discrepancy between OpenSSL and BoringSSL, as the latter returns lowercase hex values. Refs: #61459 (comment) PR-URL: #61752 Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in 4a13a62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hides a discrepancy between OpenSSL and BoringSSL, as the latter returns lowercase hex values.
Refs: #61459 (comment)