util: move TextEncoder class to C++

[anonrig]

In an attempt to improve performance, and reduce the code bloat in internal/util.js... Pending benchmark CI.

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1798/

[codecov]

Codecov Report

❌ Patch coverage is 74.31907% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.74%. Comparing base (3819c7f) to head (57c45d0).
⚠️ Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
src/encoding_binding.cc	74.21%	51 Missing and 15 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #61778    +/-   ##
========================================
  Coverage   89.74%   89.74%            
========================================
  Files         675      675            
  Lines      204642   204761   +119     
  Branches    39322    39328     +6     
========================================
+ Hits       183657   183767   +110     
- Misses      13257    13264     +7     
- Partials     7728     7730     +2     

Files with missing lines	Coverage Δ
lib/internal/encoding.js	100.00% <100.00%> (ø)
src/encoding_binding.cc	63.01% <74.21%> (+10.09%)	⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[anonrig]

Benchmarks are not good... Closing.

[joyeecheung]

Suggested change

	bs->MaxByteLength(),
	bs->ByteLength(),

This is not a resizable array buffer, so no need to use this.

[joyeecheung]

I think we should also handle the error here.

Suggested change

	std::unique_ptr<BackingStore> bs = ArrayBuffer::NewBackingStore(
	isolate, output_length, BackingStoreInitializationMode::kUninitialized);
	CHECK(bs);
	std::unique_ptr<BackingStore> bs = ArrayBuffer::NewBackingStore(
	isolate, output_length, BackingStoreInitializationMode::kUninitialized,
	BackingStoreOnFailureMode::kReturnNull);
	if (!bs) [[unlikely]] {
	THROW_ERR_MEMORY_ALLOCATION_FAILED(isolate);
	return MaybeLocal<Uint8Array>();
	}

[joyeecheung]

Suggested change

	std::unique_ptr<BackingStore> bs = ArrayBuffer::NewBackingStore(
	isolate, utf8_length, BackingStoreInitializationMode::kUninitialized);
	CHECK(bs);
	std::unique_ptr<BackingStore> bs = ArrayBuffer::NewBackingStore(
	isolate, utf8_length, BackingStoreInitializationMode::kUninitialized,
	BackingStoreOnFailureMode::kReturnNull);
	if (!bs) [[unlikely]] {
	THROW_ERR_MEMORY_ALLOCATION_FAILED(isolate);
	return MaybeLocal<Uint8Array>();
	}

[joyeecheung]

In this case is there really much to be gained from this juggling compared to just using WriteUtf8V2?

[joyeecheung]

I think this will make it even slower than dictionary objects? Dictionary is only slow in comparison to fast properties whose reads get compiled into a memory offset read. If it's in comparison to jumping through the hoops to invoke a C++ accessor it's still faster.

[joyeecheung]

You can just use the SetProtoMethodNoSideEffect helpers for these methods? If you need to set length you can just add a new parameter to that.