lib: optimize styleText when validateStream is false#61792
Open
RafaelGSS wants to merge 1 commit intonodejs:mainfrom
Open
lib: optimize styleText when validateStream is false#61792RafaelGSS wants to merge 1 commit intonodejs:mainfrom
RafaelGSS wants to merge 1 commit intonodejs:mainfrom
Conversation
This commit optimizes the util.styleText when validateStream is false Co-Authored-By: Bruno Rodrigues <swe@brunocroh.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Member
Author
|
@BridgeAR In our understanding to further optimize this, we would need to encapsulate this API into a Any objections to us pursuing that idea in a separate PR? |
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61792 +/- ##
==========================================
- Coverage 89.76% 89.73% -0.03%
==========================================
Files 675 675
Lines 204674 204689 +15
Branches 39330 39311 -19
==========================================
- Hits 183716 183675 -41
- Misses 13235 13300 +65
+ Partials 7723 7714 -9
π New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit optimizes the util.styleText when validateStream is false
We are investigating how we can further optimise it without changing the API drastically.