test: fix flaky test-http2-close-while-writing

[Han5991]

The test was flaky due to a race condition where client.close() would
wait for a graceful shutdown while the server had already destroyed the
session/stream, leading to a timeout.

Changes:

• Replace client.close() with client.destroy() in the close event
  handler of the client stream.
• Add common.mustNotCall() error handlers to the client, client stream,
  and server session to catch unexpected errors.
• Add check if (!client_stream.destroyed) before destroying client
  stream in the server's data handler.

Refs: #33156

[lpinca]

Suggested change

session.on('error', common.mustNotCall());

This is already covered by the default behavior of unhandled 'error' events.

[lpinca]

Suggested change

	process.nextTick(() => {
	if (!client_stream.destroyed) {
	client_stream.destroy();
	}
	});
	process.nextTick(() => client_stream.destroy());

This is already done in the stream.destroy() implementation.

[lpinca]

Suggested change

client.on('error', common.mustNotCall());

[lpinca]

Suggested change

client_stream.on('error', common.mustNotCall());

[lpinca]

It is still not clear to me why this callback

node/lib/internal/http2/core.js

Lines 2192 to 2196 in 6710c00

	const writeCallback = (err) => {
	waitingForWriteCallback = false;
	writeCallbackErr = err;
	done();
	};

is not called. See #58252.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (3d30c30) to head (df7750e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61804      +/-   ##
==========================================
+ Coverage   89.75%   89.76%   +0.01%     
==========================================
  Files         675      675              
  Lines      204676   204731      +55     
  Branches    39329    39343      +14     
==========================================
+ Hits       183705   183779      +74     
+ Misses      13272    13238      -34     
- Partials     7699     7714      +15     

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.