-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
vm: DONT_CONTEXTIFY when no contextObject set #62459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
legendecas
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
legendecas:vm-strict
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| 'use strict'; | ||
| require('../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| const vm = require('vm'); | ||
|
|
||
| // Declared with `var`. | ||
| { | ||
| const ctx = vm.createContext(); | ||
| vm.runInContext(`"use strict"; var x; x = 42;`, ctx); | ||
| assert.strictEqual(ctx.x, 42); | ||
| } | ||
|
|
||
| // Define on `globalThis`. | ||
| { | ||
| const ctx = vm.createContext(); | ||
| vm.runInContext(` | ||
| "use strict"; | ||
| Object.defineProperty(globalThis, "x", { | ||
| configurable: true, | ||
| value: 42, | ||
| }); | ||
| `, ctx); | ||
| const ret = vm.runInContext(`"use strict"; x`, ctx); | ||
| assert.strictEqual(ret, 42); | ||
| assert.strictEqual(ctx.x, 42); | ||
| } | ||
|
|
||
| // Set on globalThis. | ||
| { | ||
| const ctx = vm.createContext(); | ||
| vm.runInContext(`"use strict"; globalThis.x = 42`, ctx); | ||
| const ret = vm.runInContext(`"use strict"; x`, ctx); | ||
| assert.strictEqual(ret, 42); | ||
| assert.strictEqual(ctx.x, 42); | ||
| } | ||
|
|
||
| // Set on context. | ||
| // Should throw a ReferenceError when a variable is not defined in strict-mode. | ||
| assert.throws(() => vm.runInNewContext(`"use strict"; x = 42`), | ||
| /ReferenceError: x is not defined/); | ||
|
|
||
| // Known issue since V8 14.6. | ||
| // When the context is a "contextified" object, ReferenceError can not be thrown. | ||
| // TODO(legendecas): https://github.com/nodejs/node/pull/61898#issuecomment-4142811603 | ||
| // Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7474608 | ||
| { | ||
| const ctx = vm.createContext({}); | ||
| assert.throws(() => vm.runInContext(`"use strict"; x = 42`, ctx), | ||
| /ReferenceError: x is not defined/); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
assert.throwsneeds to be removed when #61898 lands.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that if this lands first, 61898 will CI will fail or...? Just want to make sure it's not easily missed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this lands first, 61898 will need updating this test as a known issue, as #61898 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, we can land after #61898. This PR is trying to remediate #61898 (comment).