test: add graceful handling of test-debugger-pid flakes#62472
Open
jasnell wants to merge 1 commit intonodejs:mainfrom
Open
test: add graceful handling of test-debugger-pid flakes#62472jasnell wants to merge 1 commit intonodejs:mainfrom
jasnell wants to merge 1 commit intonodejs:mainfrom
Conversation
The test-debugger-pid test has been flaky in CI. The apparent cause is that the test appears to hang if some other test happens to leave something stuck running on port 9229. This change adds a check to see if the port is available before attempting to test and skips if the port is in use. It also adds more graceful timeout handling to the test. Admittedly, this is a band-aid for the underlying issue, which appears to be that some other test is not cleaning up properly. We don't know which test that is, so for now let's try to handle the symptom gracefully. Reliability-report: https://github.com/nodejs/reliability/blob/main/reports/2026-03-28.md Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus 4.6
nodejs-github-bot
added
needs-ci
jasnell
added
flaky-test
Member
I will not block but no, that's not how I would handle it. Applying a buffer solution to tests defeats their purpose. |
Member
Author
|
Yep, understood. I'm not too sold on this approach either. Hmmm... |
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62472 +/- ##
=======================================
Coverage 89.70% 89.71%
=======================================
Files 691 691
Lines 213935 213935
Branches 41050 41047 -3
=======================================
+ Hits 191907 191923 +16
- Misses 14095 14106 +11
+ Partials 7933 7906 -27 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test-debugger-pid test has been flaky in CI. The apparent cause is that the test appears to hang if some other test happens to leave something stuck running on port 9229. This change adds a check to see if the port is available before attempting to test and skips if the port is in use. It also adds more graceful
timeout handling to the test.
Admittedly, this is a band-aid for the underlying issue, which appears to be that some other test is not cleaning up properly. We don't know which test that is, so for now let's try to handle the symptom gracefully.
Whether this is the way we want to handle this flake is an open question.
Reliability-report: https://github.com/nodejs/reliability/blob/main/reports/2026-03-28.md
Signed-off-by: James M Snell jasnell@gmail.com
Assisted-by: Opencode/Opus 4.6