stream: expose ReadableStreamTee#64195
Conversation
|
Review requested:
|
|
I don't know if we should be exposing this as a top-level function. At the very least, we should mark Ideally, we land on a solution in the Streams standard itself. The current proposal is to add an options bag to |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
4430357 to
fb6e605
Compare
This would be great, but it doesn't look like browsers have any interest in implementing it, considering the issue is nearly 5 years old. |
|
@KhafraDev @MattiasBuelens should we expose this verbatim or change the name to |
|
ReadableStreamTee might be a little verbose. Honestly the only reason I didn't try implementing this myself was because I don't particularly like the verbose name, but didn't have any better ideas |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Commit Queue failed- Loading data for nodejs/node/pull/64195 ✔ Done loading data for nodejs/node/pull/64195 ----------------------------------- PR info ------------------------------------ Title stream: expose ReadableStreamTee (#64195) Author Matteo Collina <matteo.collina@gmail.com> (@mcollina) Branch mcollina:expose-readable-stream-tee -> nodejs:main Labels stream, semver-minor, commit-queue-squash Commits 2 - stream: expose ReadableStreamTee - doc: mark ReadableStreamTee as experimental Committers 1 - Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/64195 Refs: https://github.com/nodejs/undici/issues/5358 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64195 Refs: https://github.com/nodejs/undici/issues/5358 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 29 Jun 2026 09:01:30 GMT ✔ Approvals: 2 ✔ - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/64195#pullrequestreview-4594006348 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64195#pullrequestreview-4629919230 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/28718869468 |
|
Landed in 4d27d80 |
Refs: nodejs/undici#5358
Expose
ReadableStreamTee()so Fetch body clone can usecloneForBranch2.