Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/internal/quic/quic.js
Original file line number Diff line number Diff line change
Expand Up @@ -2313,6 +2313,7 @@ class QuicStream {
getQuicSessionState(stream.#inner.session).internalErrorCode;
handle.resetStream(code);
if (drainWakeup != null) {
markPromiseAsHandled(drainWakeup.promise);
drainWakeup.reject(error);
drainWakeup = null;
}
Expand Down Expand Up @@ -2508,6 +2509,9 @@ class QuicStream {
}
if (error !== undefined) {
inner.pendingClose.reject(error);
if (!inner.destroying && typeof inner.onerror === 'function') {
invokeOnerror(inner.onerror, error);
}
} else {
inner.pendingClose.resolve();
}
Expand Down
54 changes: 54 additions & 0 deletions test/parallel/test-quic-stream-writer-unhandled-error.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
// Flags: --experimental-quic --no-warnings

// Test: Verify that when a peer resets a stream after writer.endSync()
// is called, the stream.onerror handler fires and no unhandled rejection occurs.

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import * as assert from 'node:assert';

const { rejects, strictEqual } = assert;

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { listen, connect } = await import('../common/quic.mjs');

const serverDone = Promise.withResolvers();

// Listen for unhandled rejections to catch regressions.
process.on('unhandledRejection', (reason) => {
assert.fail(`Unhandled rejection: ${reason}`);
});

const serverEndpoint = await listen(mustCall((serverSession) => {
serverSession.onstream = mustCall(async (stream) => {
// Set up onerror to verify it fires on remote reset
const errorFired = Promise.withResolvers();
stream.onerror = mustCall((error) => {
strictEqual(error.code, 'ERR_QUIC_APPLICATION_ERROR');
strictEqual(error.errorCode, 256n);
errorFired.resolve();
});

stream.sendHeaders({ ':status': '200' });
stream.writer.endSync();

await errorFired.promise;
await rejects(stream.closed);

serverSession.close();
serverDone.resolve();
});
}));

const clientSession = await connect(serverEndpoint.address);
await clientSession.opened;

const stream = await clientSession.createBidirectionalStream();
stream.resetStream(256n);
await rejects(stream.closed);

await serverDone.promise;
await clientSession.close();
await serverEndpoint.close();
Loading