Skip to content

chore(deps): bump doc-kit in remark-lint#8694

Merged
avivkeller merged 1 commit intomainfrom
bump-doc-kit
Mar 8, 2026
Merged

chore(deps): bump doc-kit in remark-lint#8694
avivkeller merged 1 commit intomainfrom
bump-doc-kit

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Mar 4, 2026

This bump will enable Dependabot to bump doc-kit in the future.

Why is the diff so big?

The version of doc-kit previously used was extremely out-of-date, and had a number of dependencies no longer needed (i.e. the old, extremely large Orama bundle)

@avivkeller avivkeller requested review from a team as code owners March 4, 2026 21:54
Copilot AI review requested due to automatic review settings March 4, 2026 21:54
@vercel
Copy link

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Mar 6, 2026 8:28pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

@avivkeller
Copy link
Member Author

Vercel is not enjoying this git-hosted dependency, it seems. So, this is blocked by nodejs/doc-kit#624.

Error: Command "pnpm install --prod" exited with SIGKILL
Error: pnpm install failed with SIGKILL. There may be unexpected items in the build cache. Try redeploying without the build cache. Learn More: https://vercel.com/docs/deployments/managing-deployments#redeploy-a-project

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the @nodejs/doc-kit dependency used by the @node-core/remark-lint package to a newer git commit so future remark-lint rules can rely on updated doc-kit logic (e.g., more accurate regexes).

Changes:

  • Update @nodejs/doc-kit git SHA in packages/remark-lint/package.json.
  • Regenerate pnpm-lock.yaml to reflect the new doc-kit commit and its updated dependency graph.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/remark-lint/package.json Updates the doc-kit git reference used by the remark-lint package.
pnpm-lock.yaml Updates the lockfile to match the new doc-kit commit and its transitive dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.51 MB
New Total Size 3.51 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/922a4bdf359e3461.js 208.15 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/c99703d3755c63d7.js 208.15 KB

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.11%. Comparing base (5bd8796) to head (575813e).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8694      +/-   ##
==========================================
+ Coverage   75.06%   75.11%   +0.04%     
==========================================
  Files         104      104              
  Lines        9161     9161              
  Branches      316      315       -1     
==========================================
+ Hits         6877     6881       +4     
+ Misses       2282     2278       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member Author

cc @nodejs/web-infra for reviewed

@avivkeller avivkeller enabled auto-merge March 7, 2026 20:51
@avivkeller avivkeller added this pull request to the merge queue Mar 8, 2026
Merged via the queue into main with commit a50cc89 Mar 8, 2026
12 checks passed
@avivkeller avivkeller deleted the bump-doc-kit branch March 8, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants