fix(h2): fix flaky stream end handling on macOS #4762
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dispatcher#Connecttest on macOS intest/http2-dispatcher.jsresponseReceivedflag to properly distinguish between normal completion and error casesProblem
The test was failing intermittently on macOS with:
The root cause was a stream state check
stream.state.state < 6that excluded state 6 (HALF_CLOSED_REMOTE). However, this is a valid state when the server finishes sending its response. Timing differences across platforms caused the stream to be in state 6 when 'end' fired, triggering a false error.Fix
Instead of checking stream state (which is timing-dependent), track whether we received a response:
responseReceivedflag set totruewhen 'response' event firesThis properly differentiates between:
Test plan
Dispatcher#Connecttest passes (the originally flaky test)Should throw informational error on half-closed streams (remote)passes (error case still works)