fix: properly close idle connections in encoding test #4763
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test `should allow exactly 5 content-encodings` in test/fetch/encoding.js was failing intermittently on macOS with ECONNRESET errors due to improper connection cleanup. Changed both `after()` hooks to call `server.closeIdleConnections()` before closing the server, ensuring idle connections are properly drained rather than abruptly terminated. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4763 +/- ##
==========================================
+ Coverage 93.26% 93.27% +0.01%
==========================================
Files 109 109
Lines 34029 34029
==========================================
+ Hits 31738 31742 +4
+ Misses 2291 2287 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test/fetch/encoding.jstest that fails intermittently on macOS withECONNRESETerrorsafter()hooks to callserver.closeIdleConnections()before closing the serverTest plan
🤖 Generated with Claude Code