fix(types): export MockAgent pending interceptor type#5565
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PendingInterceptorthrough theMockAgentnamespacependingInterceptors()and its formatter reference the public namespaced typesWhy
MockAgent#pendingInterceptors()returned a declaration-private interface, so consumers could inspect the values but could not name the return element type in their own TypeScript APIs. The existing mock-agent type test had to duplicate that interface locally.Validation
npx tsdnpx tsc test/imports/undici-import.ts --typeRoots ./types --noEmitnpx tsc <all types/*.d.ts files> --noEmit --typeRoots ./typesnpm run lint -- --no-cacheFixes #5563