fix: preserve DNS origin hostname on sockets#5577
Open
cyphercodes wants to merge 2 commits into
Open
Conversation
Signed-off-by: cyphercodes <cyphercodes@users.noreply.github.com>
metcoder95
approved these changes
Jul 21, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5577 +/- ##
=======================================
Coverage 93.47% 93.48%
=======================================
Files 110 110
Lines 37564 37581 +17
=======================================
+ Hits 35114 35132 +18
+ Misses 2450 2449 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: cyphercodes <cyphercodes@users.noreply.github.com>
Author
|
Pushed a small test-only follow-up in 306602e to avoid relying on the Verification run locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #5573
Rationale
The DNS interceptor connects to a selected IP address, which causes Node's
net.client.socketdiagnostics channel to expose the IP assocket._host. Consumers can no longer correlate TCP connection timing with the original request hostname.Changes
socket._hostandremoteAddressFeatures
N/A
Bug Fixes
Breaking Changes and Deprecations
N/A
Status
Testing:
node --test --test-name-pattern='#5573' test/interceptors/dns.jsnpm run test:interceptorsnpm run lintnpm run test:typescript