feat(tls-create-secure-pair-deprecation): handle Node.js DEP0064 migration#266
Open
technologic-technologic wants to merge 15 commits intonodejs:mainfrom
Open
Conversation
Member
|
Missing import test case
|
…d ESM default and dynamic import cases
…uded default and dynamic ESM imports + needed refactors as PR comments) WHAT Changed: - AST-based migration - ESM/default/dynamic cases - Normalize rewritten CJS requires to `node:tls` as suggested to code section - Remove duplicated `getNodeImportStatements/getNodeRequireCalls` invocations that attempted to handle `'node:tls'` vs `'tls'`
…d dynamic import (await/then) WHAT : - ESM default import - ESM dynamic import (await assignment) - ESM dynamic import (then callback)
…cation`)' into feat(`tls-createSecurePair-deprecation`)
Member
|
Thanks for this! |
Member
|
bump @technologic-technologic 👋 |
AugustinMauroy
added
the
awaiting author
AugustinMauroy
force-pushed
the
feat(`tls-createSecurePair-deprecation`)
branch
from
62a736a to
da7d3c8
Compare
Member
|
@JakobJingleheimer i had take hand here, it's much more lighter |
AugustinMauroy
force-pushed
the
feat(`tls-createSecurePair-deprecation`)
branch
from
2268a5e to
c7b610f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the codemod to replace deprecated
tls.createSecurePair()withTLSSocket, addressing DEP0064.tls.createSecurePair()depreciation #127Changes included:
createSecurePair(...)intonew TLSSocket(underlyingSocket, {...}), preservingtls.TLSSocketfor namespace usage.{ createSecurePair }with{ TLSSocket }in CJS/ESM (keeps namespace imports intact).pair→socketwhere applicable.This PR is part of the feature branch
feat/tls-createSecurePair-to-TLSSocket.