feat(`axios-to-whatwg-fetch`): introduce by AugustinMauroy · Pull Request #269 · nodejs/userland-migrations

AugustinMauroy · 2025-11-08T11:52:29Z

Related issue

close #191

JakobJingleheimer · 2025-11-09T11:41:11Z

omg please yes

AugustinMauroy · 2025-12-13T09:46:57Z

cc @nodejs/userland-migrations can I have first review on this one

recipes/axios-to-whatwg-fetch/src/workflow.ts

JakobJingleheimer

This is a great initial implementation 🙂

I think it would be better to consolidate the config handling into a helper since all axios methods support it.

Blocker: There are some axios config options that are not supported here, and, if present in userland code, the absence of support will surely break that userland code. For instance:

transformResponse I think that can probably just be converted to an initial then() prepended to the outputted fetch?

transformRequest I think this can be handled by merely setting fetch's init.body like body: transformRequest(bodyExpression). That would probably also work for paramsSerializer.

If we don't want to handle those more exotic axios config options initially, I think that's okay, but the migration needs to detect them and abort.

JakobJingleheimer · 2026-01-15T21:02:51Z

recipes/axios-to-whatwg-fetch/src/remove-dependencies.ts

This seems superfluous

We have an utility that do that so let's use it

recipes/axios-to-whatwg-fetch/src/workflow.ts

JakobJingleheimer · 2026-01-17T12:15:46Z

recipes/axios-to-whatwg-fetch/src/workflow.ts

+		},
+	},
+	{
+		oldBind: '$.request',


Let's include the axios.request or its location (file.ext:row:col) in the warning output here so the user knows what triggered.

Also, I think maybe these should be console.error instead of warning because part of the migration failed.

Let's include the axios.request or its location (file.ext:row:col) in the warning output here so the user knows what triggered.

I didn't get this

Which part don't you get?

recipes/axios-to-whatwg-fetch/src/workflow.ts

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

AugustinMauroy · 2026-01-17T15:46:43Z

@JakobJingleheimer I tried to apply all of your proposal.

But why the ci didn't ran ?

JakobJingleheimer · 2026-01-17T16:10:51Z

It looks like CI did run?

If not, was this whilst I was fiddling with the repo permissions? (I specifically told you on slack you'd temporarily have read-only permissions for a bit, which means you couldn't do anything other than read within the repo)

AugustinMauroy · 2026-01-17T16:16:20Z

It looks like CI did run?

If not, was this whilst I was fiddling with the repo permissions? (I specifically told you on slack you'd temporarily have read-only permissions for a bit, which means you couldn't do anything other than read within the repo)

it's ran after the merge commit. idk what really happened but it's work now !

it's didn't help since I dunno why windows is doing windows thing

JakobJingleheimer

Great tidy!

It's still missing handling for transformRequest, transformResponse, paramsSerializer, etc, which was the blocker before. It needs to either

support them
detect them and abort/fail the migration

Doing neither will result in broken userland code.

avivkeller · 2026-02-02T22:03:48Z

recipes/axios-to-whatwg-fetch/src/workflow.ts

+const baseUpdates: {
+	oldBind: string;
+	replaceFn: BindingToReplace['replaceFn'];
+	supportDefaultAccess?: boolean;
+}[] = [
+	{
+		oldBind: '$.get',
+		replaceFn: (args, context) => {
+			const [url, oldOptions] = args;
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.get. Skipping.');
+				return '';
+			}
+			const options = createOptions({ oldOptions });
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}${options ? `, ${options}` : ''})
+			.then(async (res) => Object.assign(res, { data: await res.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.post',
+		replaceFn: (args, context) => {
+			const url = args[0];
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.post. Skipping.');
+				return '';
+			}
+			const options = createOptions({
+				oldOptions: args[2],
+				method: 'POST',
+				bodyNode: args[1] ?? null,
+				payloadKind: 'json',
+			});
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}${options ? `, ${options}` : ''})
+			.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.put',
+		replaceFn: (args, context) => {
+			const url = args[0];
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.put. Skipping.');
+				return '';
+			}
+			const options = createOptions({
+				oldOptions: args[2],
+				method: 'PUT',
+				bodyNode: args[1] ?? null,
+				payloadKind: 'json',
+			});
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}${options ? `, ${options}` : ''})
+			.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.patch',
+		replaceFn: (args, context) => {
+			const url = args[0];
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.patch. Skipping.');
+				return '';
+			}
+			const options = createOptions({
+				oldOptions: args[2],
+				method: 'PATCH',
+				bodyNode: args[1] ?? null,
+				payloadKind: 'json',
+			});
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}${options ? `, ${options}` : ''})
+			.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.postForm',
+		replaceFn: (args, context) => {
+			const url = args[0];
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.postForm. Skipping.');
+				return '';
+			}
+			const options = createOptions({
+				oldOptions: args[2],
+				method: 'POST',
+				bodyNode: args[1] ?? null,
+				payloadKind: 'form',
+			});
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}${options ? `, ${options}` : ''})
+			.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.putForm',
+		replaceFn: (args, context) => {
+			const url = args[0];
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.putForm. Skipping.');
+				return '';
+			}
+			const options = createOptions({
+				oldOptions: args[2],
+				method: 'PUT',
+				bodyNode: args[1] ?? null,
+				payloadKind: 'form',
+			});
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}${options ? `, ${options}` : ''})
+			.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.patchForm',
+		replaceFn: (args, context) => {
+			const url = args[0];
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.patchForm. Skipping.');
+				return '';
+			}
+			const options = createOptions({
+				oldOptions: args[2],
+				method: 'PATCH',
+				bodyNode: args[1] ?? null,
+				payloadKind: 'form',
+			});
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}${options ? `, ${options}` : ''})
+			.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.delete',
+		replaceFn: (args, context) => {
+			const url = args[0];
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.delete. Skipping.');
+				return '';
+			}
+			const options = createOptions({
+				oldOptions: args[1],
+				method: 'DELETE',
+			});
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}, ${options})
+			.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.head',
+		replaceFn: (args, context) => {
+			const url = args[0];
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.head. Skipping.');
+				return '';
+			}
+			const options = createOptions({
+				oldOptions: args[1],
+				method: 'HEAD',
+			});
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}, ${options})
+			.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.options',
+		replaceFn: (args, context) => {
+			const url = args[0];
+			if (!url) {
+				warnWithLocation(context, 'Missing URL in axios.options. Skipping.');
+				return '';
+			}
+			const options = createOptions({
+				oldOptions: args[1],
+				method: 'OPTIONS',
+			});
+			return dedent.withOptions({ alignValues: true })`
+		fetch(${url.text()}, ${options})
+			.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+			.catch(() => null)
+		`;
+		},
+	},
+	{
+		oldBind: '$.request',
+		replaceFn: (args, context) => {
+			const config = args[0];
+			if (!config) {
+				warnWithLocation(
+					context,
+					'Missing config object in axios.request. Skipping.',
+				);
+				return '';
+			}
+
+			if (config.kind() !== 'object') {
+				warnWithLocation(
+					context,
+					'Unsupported axios.request configuration shape. Skipping migration.',
+					config,
+				);
+				return '';
+			}
+
+			const urlNode = getObjectPropertyValue(config, 'url');
+			if (!urlNode) {
+				warnWithLocation(
+					context,
+					'Missing URL in axios.request config. Skipping migration.',
+					config,
+				);
+				return '';
+			}
+			const url = urlNode.text();
+
+			const methodNode = getObjectPropertyValue(config, 'method');
+
+			const method = methodNode.child(1)?.text().toUpperCase();
+
+			const options = createOptions({
+				oldOptions: config,
+				method: method ?? 'GET', // axios.request's default is GET
+				bodyNode: getObjectPropertyValue(config, 'data') ?? null,
+				payloadKind: 'json',
+			});
+
+			return dedent.withOptions({ alignValues: true })`
+	fetch(${url}${options ? `, ${options}` : ''})
+		.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+		.catch(() => null)
+	`;
+		},
+	},
+];


These seem extremely repetative, can they be simplified with a loop?

Yes, exactly :)

#269 (comment)

brunocroh and others added 17 commits September 3, 2025 19:57

wip

6f94b7a

wip

e51e1cb

wip

b74ed68

wip

320dd82

wip

84c09b7

wip

9bfe594

wip

a08cf23

wip

335b801

wip

398aa8e

Merge branch 'main' into feat/axios-to-whatwg-fetch

85325e9

Update

667a821

add jsdoc

c828c60

write readme

8a5629a

test: correct white space

ca6dc94

update dep

8cf7ab6

wip

691931d

Update package-lock.json

4eb9d44

AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Nov 8, 2025

AugustinMauroy requested review from a team and removed request for a team November 8, 2025 13:49

AugustinMauroy removed the awaiting reviewer Author has responded and needs action from the reviewer label Nov 8, 2025

AugustinMauroy marked this pull request as draft November 8, 2025 13:50

AugustinMauroy added 4 commits November 24, 2025 13:14

feat(axios-to-whatwg-fetch): add support request

7064c88

WIP

560db6d

update

faf6ac2

include tsx

03a36d7

AugustinMauroy requested a review from a team December 10, 2025 10:34

AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Dec 13, 2025

AugustinMauroy added 2 commits December 15, 2025 13:58

don't use EOL ?

13893a1

fix ?

bddf181

AugustinMauroy commented Dec 15, 2025

View reviewed changes

recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated Show resolved Hide resolved

brunocroh requested a review from a team December 19, 2025 22:19

brunocroh approved these changes Jan 6, 2026

View reviewed changes

brunocroh requested a review from a team January 9, 2026 09:43

JakobJingleheimer requested changes Jan 17, 2026

View reviewed changes

JakobJingleheimer added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Jan 17, 2026

JakobJingleheimer added this to Userland Migrations Board Jan 17, 2026

JakobJingleheimer moved this to 🏗 In progress in Userland Migrations Board Jan 17, 2026

AugustinMauroy and others added 9 commits January 17, 2026 16:03

simplify

71d6cdc

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

Update recipes/axios-to-whatwg-fetch/src/workflow.ts

2d056a5

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

Update recipes/axios-to-whatwg-fetch/src/workflow.ts

8a8b987

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

Update recipes/axios-to-whatwg-fetch/src/workflow.ts

85beb77

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

Update recipes/axios-to-whatwg-fetch/src/workflow.ts

8f11004

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

WIP

890c10f

fix formating in output

2b8a759

wip

c4a29b2

WIP

baa2632

Merge branch 'main' into feat/axios-to-whatwg-fetch

631d0da

AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Jan 17, 2026

JakobJingleheimer requested changes Jan 25, 2026

View reviewed changes

JakobJingleheimer added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Jan 25, 2026

avivkeller reviewed Feb 2, 2026

View reviewed changes

Uh oh!

Conversation

AugustinMauroy commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issue

Uh oh!

JakobJingleheimer commented Nov 9, 2025

Uh oh!

AugustinMauroy commented Dec 13, 2025

Uh oh!

Uh oh!

JakobJingleheimer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AugustinMauroy commented Jan 17, 2026

Uh oh!

JakobJingleheimer commented Jan 17, 2026

Uh oh!

AugustinMauroy commented Jan 17, 2026

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

avivkeller Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AugustinMauroy commented Nov 8, 2025 •

edited

Loading

JakobJingleheimer left a comment •

edited

Loading