agents: on grpc add appVersion field to info msg#413
agents: on grpc add appVersion field to info msg#413santigimeno wants to merge 1 commit intonode-v24.x-nsolid-v6.xfrom
Conversation
WalkthroughAdds an optional string field Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-12-03T14:31:33.011ZApplied to files:
📚 Learning: 2025-12-03T14:30:08.346ZApplied to files:
🧬 Code graph analysis (2)agents/grpc/src/proto/info.pb.cc (1)
agents/grpc/src/proto/info.pb.h (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (3)
✏️ Tip: You can disable this entire section by setting Comment |
|
Yeah, that's to be expected. The console needs to update the proto files. |
It wasn't added when creating the gRPC agent. Improved tests to cover this specific issue so it doesn't happen again.
e8b3be4 to
f46c610
Compare
It wasn't added when creating the gRPC agent. Improved tests to cover this specific issue so it doesn't happen again. PR-URL: #413 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
|
Landed in c491885 |
It wasn't added when creating the gRPC agent. Improved tests to cover this specific issue so it doesn't happen again. PR-URL: #413 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
It wasn't added when creating the gRPC agent. Improved tests to cover this specific issue so it doesn't happen again. PR-URL: #413 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>



It wasn't added when creating the gRPC agent. Improved tests to cover this specific issue so it doesn't happen again.
Summary by CodeRabbit
New Features
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.