test: fix flaky test-grpc-continuous-profile#418
Closed
santigimeno wants to merge 1 commit intonode-v24.x-nsolid-v6.xfrom
Closed
test: fix flaky test-grpc-continuous-profile#418santigimeno wants to merge 1 commit intonode-v24.x-nsolid-v6.xfrom
santigimeno wants to merge 1 commit intonode-v24.x-nsolid-v6.xfrom
Conversation
A couple of changes: - Extend time between enabling/disabling cont profiles. - Fix last test to make sure it start with cont profile disabled.
WalkthroughA test file for gRPC continuous profiling was updated with increased timing delays, added console logging for profile counts, duplicated environment variable cleanup, and enhanced return value destructuring with assertions to verify profile data and request IDs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
RafaelGSS
approved these changes
Feb 3, 2026
santigimeno
added a commit
that referenced
this pull request
Feb 5, 2026
A couple of changes: - Extend time between enabling/disabling cont profiles. - Fix last test to make sure it start with cont profile disabled. PR-URL: #418 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Member
Author
|
Landed in f4360e5 |
santigimeno
added a commit
that referenced
this pull request
Feb 25, 2026
A couple of changes: - Extend time between enabling/disabling cont profiles. - Fix last test to make sure it start with cont profile disabled. PR-URL: #418 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno
added a commit
that referenced
this pull request
Feb 25, 2026
A couple of changes: - Extend time between enabling/disabling cont profiles. - Fix last test to make sure it start with cont profile disabled. PR-URL: #418 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of changes:
Summary by CodeRabbit