test: fix failing grpc agent otel tests#421
Merged
santigimeno merged 1 commit intonode-v24.x-nsolid-v6.xfrom Feb 17, 2026
Merged
test: fix failing grpc agent otel tests#421santigimeno merged 1 commit intonode-v24.x-nsolid-v6.xfrom
santigimeno merged 1 commit intonode-v24.x-nsolid-v6.xfrom
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughRefactors tests to use a shared Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
RafaelGSS
approved these changes
Feb 17, 2026
Make sure we take `service.version` into account once the fix for `appVersion` was introduced. Make sure we use the common `checkResource()` function in the tracing test too. PR-URL: #421 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
73cff3b to
edcd346
Compare
santigimeno
added a commit
that referenced
this pull request
Feb 25, 2026
Make sure we take `service.version` into account once the fix for `appVersion` was introduced. Make sure we use the common `checkResource()` function in the tracing test too. PR-URL: #421 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno
added a commit
that referenced
this pull request
Feb 25, 2026
Make sure we take `service.version` into account once the fix for `appVersion` was introduced. Make sure we use the common `checkResource()` function in the tracing test too. PR-URL: #421 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we take
service.versioninto account once the fix forappVersionwas introduced.Make sure we use the common
checkResource()function in the tracing test too.Summary by CodeRabbit
Tests
Chores