Skip to content

Fix automatically generating targets for downloaded plugins #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fcturan20 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix automatically generating targets for downloaded plugins #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Toolchain/CMake/Scripts/GeneratePluginTargetsAuto.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,17 @@ function(_nos_generate_plugin_target plugin_manifest_file_path plugin_name manif
endif()
endfunction()

function(_nos_configure_plugin plugin_manifest_file common_dependencies common_definitions)
function(_nos_configure_plugin dir plugin_manifest_file common_dependencies common_definitions)
if(NOT IS_DIRECTORY ${dir})
nos_colored_message(COLOR RED "Can't process plugin because it's not folder: ${dir}")
return()
endif()

nos_get_package_info_by_path(${plugin_manifest_file} plugin_name plugin_version manifest_json)
if("${plugin_version}" MATCHES "b")
return()
endif()

nos_colored_message(COLOR CYAN "Configuring ${plugin_name} (${plugin_version})")

set(old_cmake_source_dir ${CMAKE_CURRENT_SOURCE_DIR})
Expand Down Expand Up @@ -167,7 +176,7 @@ function(_nos_process_plugin_directories_recursive dir common_dependencies commo
list(GET PLUGINS 0 plugin_manifest_filepath)
get_filename_component(plugin_name "${plugin_manifest_filepath}" NAME)

_nos_configure_plugin(${plugin_manifest_filepath} "${common_dependencies}" "${common_definitions}")
_nos_configure_plugin(${dir} ${plugin_manifest_filepath} "${common_dependencies}" "${common_definitions}")
endif()

file(GLOB SUBDIRS RELATIVE ${dir} ${dir}/*)
Expand Down