fix: address quality review findings for v0.7.5#19
Merged
noexecstack merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
- Promote _ReconnectState constants to ClassVar (was leaking into __init__/__eq__) - Fix thread-safety gap in LiveFlowStore.suspend_capture() - Fix incorrect --capture-file help text (said 'Append', code does overwrite) - CI lint/typecheck jobs now install from .[dev] for consistent tool versions - Expand .gitignore with common Unix/Linux/IDE entries - Add 14 CLI integration tests (134 total)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ReconnectStatedataclass: promote_DELAY_INIT/_DELAY_MAXtoClassVarLiveFlowStore.suspend_capture()--capture-filehelp text ("Append" -> "Write").[dev]instead of unpinned ad-hoc installs.gitignorewith common Unix/Linux/IDE entriestests/test_cli.py, 134 total)Test plan
pytest -v-- 134 tests passingruff check .-- cleanruff format --check .-- clean