Open
Conversation
Contributor
Author
|
I have unpushed drafts to decrypt value-string-based secrets, supporting round-tripping back out of this format. I need to test that more that ansible-playbook in use decrypts even each-item-in-a-list formulation that's caused the most code headache so far, not just values and dicts, and lists as a whole. |
Collaborator
|
I'm not a fan of these inline secrets vars. Unless the tooling has improved, I found it a pain to deal with the vars this way. I prefer the "vault" style in #458. It's easy enough to If we do want to switch to this style, can we ad a bit of documentation about how to use these? |
Merged
SuperQ
requested changes
Apr 1, 2026
Collaborator
SuperQ
left a comment
There was a problem hiding this comment.
No, really, I don't like doing it this way. Please address my comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answering calls to make the secret names searchable, both on github and locally, and to see more meaningful and well-scoped diffs