Conversation
chore: reposition modules roadmap around validation
|
Strix is installed on this repository, but we could not run this PR security review because this workspace does not have an active plan. If you'd like to continue receiving code reviews, you can add a payment method or manage billing here. |
djm81
added
documentation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
📝 WalkthroughOpenSpec Roadmap Repositioning: Validation-First FocusThis documentation-only PR recenters the modules-side OpenSpec roadmap around SpecFact as the validation and AI‑bloat defense tool. It reorganizes planning into Status Snapshot / Tracks / Waves, archives completed validation work, parks non-validation expansions, and rewrites active runtime/context-adapter proposals to emphasize producing validation evidence and AI‑IDE remediation handoffs. No code, manifests, package versions, or exported APIs are modified. Bundle and module surface
Manifest and integrity
Cross-repo (core specfact-cli) implications
Docs, pages, and CHANGELOG
OpenSpec change IDs and scenario coverage (module-specific)
Validation and implementation notes
Overall impact summary
WalkthroughReframes OpenSpec planning into track/wave status, rewrites several module proposals toward runtime evidence/import/validation scopes, and adds many specification contracts for review findings, CLI behavior, docs validation, backlog safety, and safe runtime writes. ChangesRoadmap & Planning
Module proposal scope rewrites (evidence/runtime framing)
Code-review, simplification, and related specs
CLI, prompts, tool diagnostics
Backlog, project, import, and runtime write safety
Docs publishing, packaged resources, and integrity gates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Focus notes (correctness/security/regressions): changes are documentation/spec-only; verify no code-level contract text was accidentally introduced as normative implementation detail; confirm references to issue numbers and artifact paths are accurate before downstream automation consumes these docs. ✨ Finishing Touches🧪 Generate unit tests (beta)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19cc5eb7e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 11
🧹 Nitpick comments (1)
openspec/specs/review-run-command/spec.md (1)
176-176: 💤 Low valueSimplify the scenario prose and reduce implementation detail.
The scenario text includes bold-formatted type signatures and overly specific implementation details (e.g.,
runsignaturefiles: list[Path]). Spec scenarios should describe observable behavior and user-facing contracts, not internal type signatures. Consider rephrasing to focus on the user-facing distinction: "pass explicit file paths as positional arguments, or use--scope/--pathflags for auto-discovery."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openspec/specs/review-run-command/spec.md` at line 176, The scenario prose is too implementation-specific (mentions internal type signatures like files: list[Path]); update the text to describe only the user-facing behavior: remove the bold type signature and rephrase to say users can either pass explicit file paths as positional arguments or use the --scope / --path flags to auto-discover targets from the repo, keeping references to the run command and the flags (--scope, --path) but omitting internal type details.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openspec/specs/ai-ide-remediation-handoff/spec.md`:
- Around line 3-4: Replace the placeholder "TBD" under the "## Purpose" header
with a concise purpose statement that clearly describes the spec's scope: define
the validation evidence handoff process for AI IDE remediation, including what
evidence is transferred, who the stakeholders are, handoff triggers, and success
criteria; locate the "## Purpose" section in the spec (the line starting with
"## Purpose") and update its content to reflect the validation evidence handoff
scope and intended outcomes.
In `@openspec/specs/backlog-sync/spec.md`:
- Around line 65-69: The phrase "MAY rewrite that managed artifact
deterministically" is contradictory; update the specification text for the
scenario that references `.specfact` to use a normative modal to express
consistent behavior (e.g., replace "MAY" with "SHALL" or "SHOULD" as
appropriate) so the contract is clear—modify the sentence in "Default managed
baseline state updates deterministically" replacing "MAY rewrite that managed
artifact deterministically" with "SHALL rewrite that managed artifact
deterministically" (or "SHOULD" if you want a softer mandate) and keep the rest
of the clause about treating it as SpecFact-managed state unchanged.
In `@openspec/specs/ci-integration/spec.md`:
- Line 47: The spec line is ambiguous about which workflow triggers the "re-sign
on pull_request synchronize" behavior; update the text to explicitly state that
this scenario is driven by the PR auto-sign workflow
(.github/workflows/sign-modules.yml) which runs on pull_request (synchronize)
and performs git push of signed manifests (and therefore must skip bot-authored
commits), and clarify that sign-modules-on-approval.yml only runs on
pull_request_review when the review is approved and is not the
synchronize-triggered signer.
In `@openspec/specs/ci-module-signing-on-approval/spec.md`:
- Line 17: The spec removed an important clarification about how the merge-base
for payload discovery is computed; restore a sentence clarifying that discovery
should be computed "since origin/dev" and not merely "divergent from the moving
`origin/dev` tip" (or else update the wording to unambiguously describe the new
intended merge-base computation), so update the text around the
merge-base/merge-base discovery wording (look for the paragraph referencing
merge-base or payload discovery) to reintroduce that exact behavioral
expectation or replace it with precise wording that matches the implementation.
- Line 14: Update openspec/specs/ci-module-signing-on-approval/spec.md to
explicitly define “trusted reviewer” to match the workflow gate in
.github/workflows/sign-modules-on-approval.yml (i.e., a reviewer whose
github.event.review.user.author_association is one of COLLABORATOR, MEMBER, or
OWNER and whose review state is approved, and include that this gate controls
access to SPECFACT_MODULE_PRIVATE_SIGN_KEY and
SPECFACT_MODULE_PRIVATE_SIGN_KEY_PASSPHRASE); also restore the archived
parenthetical clarification about “merge-base with origin/dev” (e.g., “not
merely divergent from the moving origin/dev tip”) so the spec’s merge-base
requirement cannot be misinterpreted.
In `@openspec/specs/code-review-ai-bloat-detection/spec.md`:
- Line 12: Update the category enumeration in the code-review pipeline spec to
include the new ai_bloat category: add `ai_bloat` alongside the existing values
listed on the line that currently reads `naming | kiss | yagni | dry | solid |
clean_code | architecture`, ensuring `.specfact/code-review.json` is updated via
an additive strict-schema change so `ReviewFinding.category` recognizes
`ai_bloat`; also document that `ai_bloat` is used as the policy-pack `principle`
for AI-bloat rules and that findings under `ai_bloat` must emit at `info`
severity only and remain score-neutral in v1.
In `@openspec/specs/code-review-simplification-feedback/spec.md`:
- Line 13: The review-finding-model lacks the simplification metadata fields
declared in code-review-simplification-feedback; update
openspec/specs/review-finding-model/spec.md to either (A) add the top-level
fields confidence, rewrite_hint, canonical_pattern, intent_key,
estimated_deletion_lines, related_locations into the Finding schema (matching
types and descriptions from code-review-simplification-feedback) or (B)
explicitly document the mapping that these fields are stored inside
remediation_packet (or another container), include the exact JSON shape/example
and update schema validation rules for Finding, and mention how these relate to
existing signal_trace, preserve_reasons and remediation_packet so
consumers/validators have a single consistent contract. Ensure you reference the
exact field names (confidence, rewrite_hint, canonical_pattern, intent_key,
estimated_deletion_lines, related_locations, signal_trace, preserve_reasons,
remediation_packet) and add or update schema examples and validation rules
accordingly.
In `@openspec/specs/guided-simplification-review/spec.md`:
- Line 21: Update the guided-simplification-review spec so that findings with
action "preserve" use the field name preserve_reasons (plural) instead of
preserve_reason, and reference the same closed taxonomy defined by
ReviewFinding.preserve_reasons in the review-finding-model spec; locate the
occurrence of preserve_reason in the guided-simplification-review spec and
replace it with preserve_reasons and add/point to the taxonomy enumeration used
by ReviewFinding.preserve_reasons to ensure both specs share the identical field
name and allowed values.
In `@openspec/specs/module-command-overview/spec.md`:
- Around line 3-4: Replace the placeholder "TBD" under the "## Purpose" heading
in the module-command-overview spec with a concise purpose statement that
describes this document as the canonical, deterministic definition of the
modules runtime command surface used for validation, tooling, and AI IDE
consumers; mention it supports generation of command-overview artifacts, enables
automated validation and reproducible documentation, and serves as the
authoritative input for IDE integrations and AI assistants that need a stable
command API.
In `@openspec/specs/modules-docs-publishing/spec.md`:
- Around line 68-77: Update the terminology to exactly match the formal defect
category name used in modules-pre-commit-quality-parity: replace the phrases
"published-route link validation" and "broken published-route link" with the
formal token `published-link` (including backticks) in the requirement/Scenario
text so the docs review CI wording exactly matches the local validator category.
In `@openspec/specs/prompt-command-validation/spec.md`:
- Around line 3-4: Replace the placeholder "TBD" under the "## Purpose" heading
with a concise Purpose statement that frames this spec as defining bundle prompt
validation against the mounted CLI contract to prevent drift between operational
guidance and shipped module behavior; explicitly state that the spec mandates
validating prompt-generated commands and flags against the mounted CLI contract
to ensure prompts remain consistent with the module's actual CLI surface and to
catch mismatches before release.
---
Nitpick comments:
In `@openspec/specs/review-run-command/spec.md`:
- Line 176: The scenario prose is too implementation-specific (mentions internal
type signatures like files: list[Path]); update the text to describe only the
user-facing behavior: remove the bold type signature and rephrase to say users
can either pass explicit file paths as positional arguments or use the --scope /
--path flags to auto-discover targets from the repo, keeping references to the
run command and the flags (--scope, --path) but omitting internal type details.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 66dc94a2-06fb-470d-950f-f24533f67166
📒 Files selected for processing (159)
openspec/CHANGE_ORDER.mdopenspec/changes/architecture-01-solution-layer/proposal.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/.openspec.yamlopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/design.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/proposal.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/clean-code-analysis/spec.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/code-review-simplification-feedback/spec.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/review-finding-model/spec.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/review-run-command/spec.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/tasks.mdopenspec/changes/archive/2026-06-06-code-review-12-guided-simplification-enforcement/.openspec.yamlopenspec/changes/archive/2026-06-06-code-review-12-guided-simplification-enforcement/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-code-review-12-guided-simplification-enforcement/design.mdopenspec/changes/archive/2026-06-06-code-review-12-guided-simplification-enforcement/proposal.mdopenspec/changes/archive/2026-06-06-code-review-12-guided-simplification-enforcement/specs/guided-simplification-review/spec.mdopenspec/changes/archive/2026-06-06-code-review-12-guided-simplification-enforcement/specs/review-finding-model/spec.mdopenspec/changes/archive/2026-06-06-code-review-12-guided-simplification-enforcement/specs/review-run-command/spec.mdopenspec/changes/archive/2026-06-06-code-review-12-guided-simplification-enforcement/tasks.mdopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/.openspec.yamlopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/README.mdopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/design.mdopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/proposal.mdopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/specs/ai-ide-remediation-handoff/spec.mdopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/specs/cleanup-forecast-review/spec.mdopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/specs/review-finding-model/spec.mdopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/specs/review-run-command/spec.mdopenspec/changes/archive/2026-06-06-code-review-13-cleanup-forecast-agent-handoff/tasks.mdopenspec/changes/archive/2026-06-06-code-review-ai-bloat-detection/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-code-review-ai-bloat-detection/design.mdopenspec/changes/archive/2026-06-06-code-review-ai-bloat-detection/proposal.mdopenspec/changes/archive/2026-06-06-code-review-ai-bloat-detection/specs/code-review-ai-bloat-detection/spec.mdopenspec/changes/archive/2026-06-06-code-review-ai-bloat-detection/tasks.mdopenspec/changes/archive/2026-06-06-codebase-import-runtime-hardening/.openspec.yamlopenspec/changes/archive/2026-06-06-codebase-import-runtime-hardening/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-codebase-import-runtime-hardening/design.mdopenspec/changes/archive/2026-06-06-codebase-import-runtime-hardening/proposal.mdopenspec/changes/archive/2026-06-06-codebase-import-runtime-hardening/specs/bundle-packaged-resources/spec.mdopenspec/changes/archive/2026-06-06-codebase-import-runtime-hardening/specs/codebase-import-runtime/spec.mdopenspec/changes/archive/2026-06-06-codebase-import-runtime-hardening/tasks.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/.openspec.yamlopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/design.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/proposal.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/bundle-overview-pages/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-docs-command-validation/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-docs-publishing/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-pre-commit-quality-parity/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/review-run-command/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/tasks.mdopenspec/changes/archive/2026-06-06-marketplace-07-pr-auto-sign-updates/.openspec.yamlopenspec/changes/archive/2026-06-06-marketplace-07-pr-auto-sign-updates/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-marketplace-07-pr-auto-sign-updates/design.mdopenspec/changes/archive/2026-06-06-marketplace-07-pr-auto-sign-updates/proposal.mdopenspec/changes/archive/2026-06-06-marketplace-07-pr-auto-sign-updates/specs/ci-integration/spec.mdopenspec/changes/archive/2026-06-06-marketplace-07-pr-auto-sign-updates/specs/ci-module-signing-on-approval/spec.mdopenspec/changes/archive/2026-06-06-marketplace-07-pr-auto-sign-updates/tasks.mdopenspec/changes/archive/2026-06-06-project-02-plan-root-command-fix/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-project-02-plan-root-command-fix/design.mdopenspec/changes/archive/2026-06-06-project-02-plan-root-command-fix/proposal.mdopenspec/changes/archive/2026-06-06-project-02-plan-root-command-fix/specs/project-command-surface/spec.mdopenspec/changes/archive/2026-06-06-project-02-plan-root-command-fix/tasks.mdopenspec/changes/archive/2026-06-06-project-runtime-01-safe-artifact-write-policy/.openspec.yamlopenspec/changes/archive/2026-06-06-project-runtime-01-safe-artifact-write-policy/CHANGE_VALIDATION.mdopenspec/changes/archive/2026-06-06-project-runtime-01-safe-artifact-write-policy/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-project-runtime-01-safe-artifact-write-policy/design.mdopenspec/changes/archive/2026-06-06-project-runtime-01-safe-artifact-write-policy/proposal.mdopenspec/changes/archive/2026-06-06-project-runtime-01-safe-artifact-write-policy/specs/backlog-add/spec.mdopenspec/changes/archive/2026-06-06-project-runtime-01-safe-artifact-write-policy/specs/backlog-sync/spec.mdopenspec/changes/archive/2026-06-06-project-runtime-01-safe-artifact-write-policy/specs/runtime-artifact-write-safety/spec.mdopenspec/changes/archive/2026-06-06-project-runtime-01-safe-artifact-write-policy/tasks.mdopenspec/changes/archive/2026-06-06-prompt-command-contract-validation/.openspec.yamlopenspec/changes/archive/2026-06-06-prompt-command-contract-validation/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-prompt-command-contract-validation/design.mdopenspec/changes/archive/2026-06-06-prompt-command-contract-validation/proposal.mdopenspec/changes/archive/2026-06-06-prompt-command-contract-validation/specs/bundle-packaged-resources/spec.mdopenspec/changes/archive/2026-06-06-prompt-command-contract-validation/specs/prompt-command-validation/spec.mdopenspec/changes/archive/2026-06-06-prompt-command-contract-validation/specs/resource-aware-integrity/spec.mdopenspec/changes/archive/2026-06-06-prompt-command-contract-validation/tasks.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/.openspec.yamlopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/TDD_EVIDENCE.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/proposal.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/backlog-delta/spec.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/code-review-tool-dependencies/spec.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/module-cli-error-contract/spec.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/module-command-overview/spec.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/modules-docs-command-validation/spec.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/tasks.mdopenspec/changes/governance-01-evidence-output/proposal.mdopenspec/changes/openspec-01-intent-trace/proposal.mdopenspec/changes/requirements-02-module-commands/proposal.mdopenspec/changes/requirements-03-backlog-sync/proposal.mdopenspec/changes/traceability-01-index-and-orphans/proposal.mdopenspec/changes/validation-02-full-chain-engine/design.mdopenspec/changes/validation-02-full-chain-engine/proposal.mdopenspec/changes/validation-02-full-chain-engine/tasks.mdopenspec/parking-lot/README.mdopenspec/parking-lot/backlog-kanban-01-flow-metrics/CHANGE_VALIDATION.mdopenspec/parking-lot/backlog-kanban-01-flow-metrics/proposal.mdopenspec/parking-lot/backlog-kanban-01-flow-metrics/specs/kanban-flow/spec.mdopenspec/parking-lot/backlog-kanban-01-flow-metrics/tasks.mdopenspec/parking-lot/backlog-safe-01-pi-planning/CHANGE_VALIDATION.mdopenspec/parking-lot/backlog-safe-01-pi-planning/proposal.mdopenspec/parking-lot/backlog-safe-01-pi-planning/specs/safe-pi/spec.mdopenspec/parking-lot/backlog-safe-01-pi-planning/tasks.mdopenspec/parking-lot/backlog-safe-02-risk-rollups/CHANGE_VALIDATION.mdopenspec/parking-lot/backlog-safe-02-risk-rollups/proposal.mdopenspec/parking-lot/backlog-safe-02-risk-rollups/specs/risk-rollups/spec.mdopenspec/parking-lot/backlog-safe-02-risk-rollups/tasks.mdopenspec/parking-lot/backlog-scrum-02-sprint-planning/CHANGE_VALIDATION.mdopenspec/parking-lot/backlog-scrum-02-sprint-planning/design.mdopenspec/parking-lot/backlog-scrum-02-sprint-planning/proposal.mdopenspec/parking-lot/backlog-scrum-02-sprint-planning/specs/sprint-planning/spec.mdopenspec/parking-lot/backlog-scrum-02-sprint-planning/tasks.mdopenspec/parking-lot/backlog-scrum-03-story-complexity/CHANGE_VALIDATION.mdopenspec/parking-lot/backlog-scrum-03-story-complexity/design.mdopenspec/parking-lot/backlog-scrum-03-story-complexity/proposal.mdopenspec/parking-lot/backlog-scrum-03-story-complexity/specs/story-complexity/spec.mdopenspec/parking-lot/backlog-scrum-03-story-complexity/tasks.mdopenspec/parking-lot/backlog-scrum-04-definition-of-done/CHANGE_VALIDATION.mdopenspec/parking-lot/backlog-scrum-04-definition-of-done/design.mdopenspec/parking-lot/backlog-scrum-04-definition-of-done/proposal.mdopenspec/parking-lot/backlog-scrum-04-definition-of-done/specs/definition-of-done/spec.mdopenspec/parking-lot/backlog-scrum-04-definition-of-done/tasks.mdopenspec/parking-lot/ceremony-02-requirements-aware-output/.openspec.yamlopenspec/parking-lot/ceremony-02-requirements-aware-output/CHANGE_VALIDATION.mdopenspec/parking-lot/ceremony-02-requirements-aware-output/design.mdopenspec/parking-lot/ceremony-02-requirements-aware-output/proposal.mdopenspec/parking-lot/ceremony-02-requirements-aware-output/specs/backlog-refinement/spec.mdopenspec/parking-lot/ceremony-02-requirements-aware-output/specs/ceremony-requirements-awareness/spec.mdopenspec/parking-lot/ceremony-02-requirements-aware-output/specs/daily-standup/spec.mdopenspec/parking-lot/ceremony-02-requirements-aware-output/tasks.mdopenspec/specs/ai-ide-remediation-handoff/spec.mdopenspec/specs/backlog-add/spec.mdopenspec/specs/backlog-delta/spec.mdopenspec/specs/backlog-sync/spec.mdopenspec/specs/bundle-overview-pages/spec.mdopenspec/specs/bundle-packaged-resources/spec.mdopenspec/specs/ci-integration/spec.mdopenspec/specs/ci-module-signing-on-approval/spec.mdopenspec/specs/clean-code-analysis/spec.mdopenspec/specs/cleanup-forecast-review/spec.mdopenspec/specs/code-review-ai-bloat-detection/spec.mdopenspec/specs/code-review-simplification-feedback/spec.mdopenspec/specs/code-review-tool-dependencies/spec.mdopenspec/specs/codebase-import-runtime/spec.mdopenspec/specs/guided-simplification-review/spec.mdopenspec/specs/module-cli-error-contract/spec.mdopenspec/specs/module-command-overview/spec.mdopenspec/specs/modules-docs-command-validation/spec.mdopenspec/specs/modules-docs-publishing/spec.mdopenspec/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/project-command-surface/spec.mdopenspec/specs/prompt-command-validation/spec.mdopenspec/specs/resource-aware-integrity/spec.mdopenspec/specs/review-finding-model/spec.mdopenspec/specs/review-run-command/spec.mdopenspec/specs/runtime-artifact-write-safety/spec.md
💤 Files with no reviewable changes (1)
- openspec/changes/archive/2026-06-06-code-review-ai-bloat-detection/specs/code-review-ai-bloat-detection/spec.md
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
openspec/**/*.md
⚙️ CodeRabbit configuration file
openspec/**/*.md: Specification truth: proposal/tasks/spec deltas vs. bundle behavior, CHANGE_ORDER, and
drift vs. shipped modules or docs.
Files:
openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-docs-publishing/spec.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/code-review-tool-dependencies/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/bundle-overview-pages/spec.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/modules-docs-command-validation/spec.mdopenspec/specs/backlog-add/spec.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/backlog-delta/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/bundle-packaged-resources/spec.mdopenspec/specs/codebase-import-runtime/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/review-run-command/spec.mdopenspec/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/ai-ide-remediation-handoff/spec.mdopenspec/changes/governance-01-evidence-output/proposal.mdopenspec/specs/clean-code-analysis/spec.mdopenspec/specs/module-command-overview/spec.mdopenspec/specs/cleanup-forecast-review/spec.mdopenspec/specs/guided-simplification-review/spec.mdopenspec/specs/backlog-delta/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-docs-command-validation/spec.mdopenspec/specs/module-cli-error-contract/spec.mdopenspec/specs/runtime-artifact-write-safety/spec.mdopenspec/specs/code-review-tool-dependencies/spec.mdopenspec/specs/modules-docs-publishing/spec.mdopenspec/specs/project-command-surface/spec.mdopenspec/specs/backlog-sync/spec.mdopenspec/changes/validation-02-full-chain-engine/design.mdopenspec/specs/resource-aware-integrity/spec.mdopenspec/CHANGE_ORDER.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/clean-code-analysis/spec.mdopenspec/specs/code-review-ai-bloat-detection/spec.mdopenspec/changes/requirements-03-backlog-sync/proposal.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/code-review-simplification-feedback/spec.mdopenspec/specs/ci-integration/spec.mdopenspec/specs/prompt-command-validation/spec.mdopenspec/specs/review-run-command/spec.mdopenspec/specs/ci-module-signing-on-approval/spec.mdopenspec/changes/requirements-02-module-commands/proposal.mdopenspec/specs/modules-docs-command-validation/spec.mdopenspec/changes/openspec-01-intent-trace/proposal.mdopenspec/specs/code-review-simplification-feedback/spec.mdopenspec/changes/validation-02-full-chain-engine/tasks.mdopenspec/parking-lot/README.mdopenspec/changes/validation-02-full-chain-engine/proposal.mdopenspec/changes/architecture-01-solution-layer/proposal.mdopenspec/changes/traceability-01-index-and-orphans/proposal.mdopenspec/specs/review-finding-model/spec.mdopenspec/specs/bundle-overview-pages/spec.md
🧠 Learnings (19)
📓 Common learnings
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-13T10:38:29.399Z
Learning: When a change is paired with work in specfact-cli, review the paired public change artifacts there before widening scope or redefining shared workflow semantics
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: Perform `spec -> tests -> failing evidence -> code -> passing evidence` in that order for behavior changes
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: Finalize completed OpenSpec changes with `openspec archive <change-id>` and do not manually move change folders under `openspec/changes/archive/`
📚 Learning: 2026-04-02T21:49:11.371Z
Learnt from: djm81
Repo: nold-ai/specfact-cli-modules PR: 136
File: registry/modules/specfact-spec-0.40.17.tar.gz.sha256:1-1
Timestamp: 2026-04-02T21:49:11.371Z
Learning: In nold-ai/specfact-cli-modules, module tarball signatures (registry/signatures/*.tar.sig) are generated by the `publish-modules` GitHub Actions runner during the publish workflow, not committed locally to the branch. Missing signature files should NOT be flagged as a pre-merge blocker in PRs.
Applied to files:
openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-docs-publishing/spec.mdopenspec/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/module-command-overview/spec.mdopenspec/specs/modules-docs-publishing/spec.mdopenspec/specs/ci-integration/spec.mdopenspec/specs/ci-module-signing-on-approval/spec.md
📚 Learning: 2026-04-13T10:38:29.399Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-13T10:38:29.399Z
Learning: When a change is paired with work in specfact-cli, review the paired public change artifacts there before widening scope or redefining shared workflow semantics
Applied to files:
openspec/specs/backlog-add/spec.mdopenspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/backlog-delta/spec.mdopenspec/specs/codebase-import-runtime/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/review-run-command/spec.mdopenspec/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/ai-ide-remediation-handoff/spec.mdopenspec/changes/governance-01-evidence-output/proposal.mdopenspec/specs/clean-code-analysis/spec.mdopenspec/specs/guided-simplification-review/spec.mdopenspec/specs/backlog-delta/spec.mdopenspec/specs/runtime-artifact-write-safety/spec.mdopenspec/specs/code-review-tool-dependencies/spec.mdopenspec/specs/modules-docs-publishing/spec.mdopenspec/specs/project-command-surface/spec.mdopenspec/specs/backlog-sync/spec.mdopenspec/changes/validation-02-full-chain-engine/design.mdopenspec/CHANGE_ORDER.mdopenspec/specs/code-review-ai-bloat-detection/spec.mdopenspec/changes/requirements-03-backlog-sync/proposal.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/code-review-simplification-feedback/spec.mdopenspec/specs/ci-integration/spec.mdopenspec/specs/review-run-command/spec.mdopenspec/specs/ci-module-signing-on-approval/spec.mdopenspec/changes/openspec-01-intent-trace/proposal.mdopenspec/specs/code-review-simplification-feedback/spec.mdopenspec/changes/validation-02-full-chain-engine/tasks.mdopenspec/changes/architecture-01-solution-layer/proposal.mdopenspec/changes/traceability-01-index-and-orphans/proposal.mdopenspec/specs/review-finding-model/spec.md
📚 Learning: 2026-04-13T10:38:15.855Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: .cursorrules:0-0
Timestamp: 2026-04-13T10:38:15.855Z
Learning: Adhere to worktree policy, OpenSpec gating, GitHub hierarchy-cache refresh, TDD order, quality gates, versioning, and documentation rules as defined in `docs/agent-rules/`
Applied to files:
openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/modules-docs-publishing/spec.mdopenspec/specs/review-run-command/spec.mdopenspec/changes/validation-02-full-chain-engine/tasks.md
📚 Learning: 2026-04-13T10:38:29.399Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-13T10:38:29.399Z
Learning: Treat canonical rule docs (docs/agent-rules/INDEX.md) as the source of truth for worktree policy, OpenSpec gating, GitHub completeness checks, TDD order, quality gates, versioning, and documentation rules
Applied to files:
openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/modules-docs-publishing/spec.mdopenspec/specs/review-run-command/spec.mdopenspec/specs/modules-docs-command-validation/spec.mdopenspec/changes/validation-02-full-chain-engine/tasks.md
📚 Learning: 2026-04-13T10:38:43.535Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: Treat the clean-code compliance gate as mandatory: the review surface enforces `naming`, `kiss`, `yagni`, `dry`, and `solid` categories and blocks regressions
Applied to files:
openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-pre-commit-quality-parity/spec.mdopenspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/review-run-command/spec.mdopenspec/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/clean-code-analysis/spec.mdopenspec/specs/guided-simplification-review/spec.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/clean-code-analysis/spec.mdopenspec/specs/code-review-ai-bloat-detection/spec.mdopenspec/specs/review-run-command/spec.mdopenspec/specs/code-review-simplification-feedback/spec.md
📚 Learning: 2026-04-13T10:38:22.848Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2026-04-13T10:38:22.848Z
Learning: This repository enforces the clean-code review gate through hatch run specfact code review run --json --out .specfact/code-review.json
Applied to files:
openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/review-run-command/spec.mdopenspec/specs/ai-ide-remediation-handoff/spec.mdopenspec/specs/clean-code-analysis/spec.mdopenspec/specs/cleanup-forecast-review/spec.mdopenspec/specs/guided-simplification-review/spec.mdopenspec/specs/code-review-ai-bloat-detection/spec.mdopenspec/specs/review-run-command/spec.mdopenspec/specs/code-review-simplification-feedback/spec.mdopenspec/changes/validation-02-full-chain-engine/tasks.mdopenspec/specs/review-finding-model/spec.md
📚 Learning: 2026-04-13T10:38:22.848Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2026-04-13T10:38:22.848Z
Learning: Signed module or manifest changes require version-bump review and verify-modules-signature
Applied to files:
openspec/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/modules-docs-publishing/spec.mdopenspec/specs/resource-aware-integrity/spec.mdopenspec/specs/ci-integration/spec.mdopenspec/specs/ci-module-signing-on-approval/spec.md
📚 Learning: 2026-04-13T10:38:29.399Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-13T10:38:29.399Z
Learning: Applies to **/*.{js,ts,tsx,jsx,py,java,cs,go,rb,php,cpp,c,h} : Preserve the clean-code compliance gate and its category references (naming, kiss, yagni, dry, and solid)
Applied to files:
openspec/specs/modules-pre-commit-quality-parity/spec.mdopenspec/specs/clean-code-analysis/spec.mdopenspec/specs/review-finding-model/spec.md
📚 Learning: 2026-04-13T10:38:43.535Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: Perform `spec -> tests -> failing evidence -> code -> passing evidence` in that order for behavior changes
Applied to files:
openspec/changes/governance-01-evidence-output/proposal.mdopenspec/changes/validation-02-full-chain-engine/tasks.md
📚 Learning: 2026-04-13T10:38:43.535Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: Fix SpecFact code review findings, including warnings, unless a rare explicit exception is documented
Applied to files:
openspec/specs/clean-code-analysis/spec.mdopenspec/specs/guided-simplification-review/spec.mdopenspec/specs/code-review-ai-bloat-detection/spec.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/code-review-simplification-feedback/spec.mdopenspec/specs/review-run-command/spec.mdopenspec/specs/code-review-simplification-feedback/spec.mdopenspec/specs/review-finding-model/spec.md
📚 Learning: 2026-04-13T10:38:29.399Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-13T10:38:29.399Z
Learning: Treat clean-code regressions (naming, kiss, yagni, dry, solid violations) as blocking until they are fixed or explicitly justified
Applied to files:
openspec/specs/clean-code-analysis/spec.mdopenspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/clean-code-analysis/spec.md
📚 Learning: 2026-04-13T10:38:22.848Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2026-04-13T10:38:22.848Z
Learning: Refresh .specfact/backlog/github_hierarchy_cache.md with python scripts/sync_github_hierarchy_cache.py when GitHub hierarchy metadata is missing or stale before parent or blocker work
Applied to files:
openspec/specs/backlog-sync/spec.md
📚 Learning: 2026-04-13T10:38:43.535Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: If GitHub hierarchy metadata is needed and `.specfact/backlog/github_hierarchy_cache.md` is missing or stale, refresh it with `python scripts/sync_github_hierarchy_cache.py`
Applied to files:
openspec/specs/backlog-sync/spec.md
📚 Learning: 2026-04-13T10:38:43.535Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: Enforce module signatures and version bumps when signed module assets or manifests are affected
Applied to files:
openspec/specs/resource-aware-integrity/spec.mdopenspec/specs/ci-integration/spec.mdopenspec/specs/ci-module-signing-on-approval/spec.md
📚 Learning: 2026-04-13T10:38:43.535Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: Finalize completed OpenSpec changes with `openspec archive <change-id>` and do not manually move change folders under `openspec/changes/archive/`
Applied to files:
openspec/CHANGE_ORDER.md
📚 Learning: 2026-04-13T10:38:43.535Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: Require public GitHub metadata completeness before implementation when linked issue workflow applies: parent, labels, project assignment, blockers, and blocked-by relationships
Applied to files:
openspec/changes/validation-02-full-chain-engine/tasks.md
📚 Learning: 2026-04-13T10:38:22.848Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2026-04-13T10:38:22.848Z
Learning: Work belongs on feature/*, bugfix/*, hotfix/*, or chore/* branches, normally in a worktree rooted under ../specfact-cli-modules-worktrees/
Applied to files:
openspec/changes/validation-02-full-chain-engine/tasks.md
📚 Learning: 2026-04-13T10:38:43.535Z
Learnt from: CR
Repo: nold-ai/specfact-cli-modules PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T10:38:43.535Z
Learning: Run the required verification and quality gates for the touched scope before finalization
Applied to files:
openspec/changes/validation-02-full-chain-engine/tasks.md
🪛 LanguageTool
openspec/changes/governance-01-evidence-output/proposal.md
[style] ~22-~22: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...dling based on profile/policy mode. - NEW: Evidence artifact naming and termina...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
openspec/changes/requirements-02-module-commands/proposal.md
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...for evidence usefulness by profile. - NEW: Adapter hooks return bounded records...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
openspec/specs/review-finding-model/spec.md
[style] ~14-~14: The double modal “required governed” is nonstandard (only accepted in certain dialects). Consider “to be governed”.
Context: ...HEN** the payload includes the required governed fields - AND category, severity, to...
(NEEDS_FIXED)
🔀 Multi-repo context nold-ai/specfact-cli
nold-ai/specfact-cli
-
CHANGE_ORDER and roadmap coordination
- openspec/CHANGE_ORDER.md is referenced across many openspec change documents and cross-repo alignment analysis; multiple change/task files update or require CHANGE_ORDER.md updates (e.g. openspec/changes/* tasks.md files). [::nold-ai/specfact-cli::openspec/** tasks and analysis references]
-
Evidence / governance contracts referenced
- openspec/changes/validation-02-full-chain-engine/CHANGE_VALIDATION.md mentions "governance evidence envelope; policy/profile severity consumers". [::nold-ai/specfact-cli::openspec/changes/validation-02-full-chain-engine/CHANGE_VALIDATION.md]
- Cross-change analysis notes governance-01-evidence-output as owning evidence envelope and being split/rescope (openspec/changes/archive and analysis files). [::nold-ai/specfact-cli::openspec/changes/archive/* and openspec/changes/*/analysis.md]
-
AI-bloat / simplification consumers and tests
- Tests and metadata reference ai_bloat / ai-bloat (pyproject.toml, docs/tests, unit tests): pyproject.toml includes "ai-bloat"; unit/docs tests reference ai-bloat docs pages and CI artifacts (tests/unit/docs/test_first_contact_story.py, tests/unit/scripts/test_code_review_module_docs.py). [::nold-ai/specfact-cli::pyproject.toml; tests/unit/docs/test_first_contact_story.py; tests/unit/scripts/test_code_review_module_docs.py]
- Design/spec docs explicitly mention ai_bloat defense and simplify workflows (multiple openspec change/spec files, e.g. openspec/changes/archive/.../design.md and specs). [::nold-ai/specfact-cli::openspec/changes/archive/** and openspec/specs/**]
-
Runtime evidence/validation mentions in repo
- Multiple openspec proposals/specs now talk about "validation evidence graph/runtime", "--evidence-dir", validation-evidence outputs, and sidecar evidence writers (search hits under openspec/changes/* and specs). These indicate the repo contains owners/consumers of the evidence output contract. [::nold-ai/specfact-cli::openspec/changes/* and openspec/specs/* mentioning evidence/runtime/--evidence-dir]
-
Cross-repo coordination signals
- Several openspec analysis/design files explicitly call out the need to update or sync CHANGE_ORDER.md and planning inventories across specfact-cli and specfact-cli-modules (cross-repo ownership/change-order alignment). [::nold-ai/specfact-cli::openspec/changes/archive/* and openspec/changes/*/analysis.md]
Assessment
- The PR (modules roadmap/docs-only) touches OpenSpec planning that is widely referenced in this repository (evidence/governance, ai-bloat/simplify, CHANGE_ORDER). There are direct references to governance-01 evidence envelope and ai_bloat/simplification flows in tests and specs here, so the modules repo changes are relevant and should be coordinated with specfact-cli's evidence/governance and docs/test expectations.
🔇 Additional comments (42)
openspec/CHANGE_ORDER.md (1)
1-159: LGTM!openspec/parking-lot/README.md (1)
1-60: LGTM!openspec/changes/architecture-01-solution-layer/proposal.md (1)
1-48: LGTM!openspec/changes/governance-01-evidence-output/proposal.md (1)
1-48: LGTM!openspec/changes/openspec-01-intent-trace/proposal.md (1)
1-48: LGTM!openspec/changes/requirements-02-module-commands/proposal.md (1)
1-53: LGTM!openspec/changes/requirements-03-backlog-sync/proposal.md (1)
1-49: LGTM!openspec/changes/traceability-01-index-and-orphans/proposal.md (1)
1-48: LGTM!openspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/clean-code-analysis/spec.md (1)
1-1: LGTM!openspec/changes/archive/2026-06-06-code-review-11-simplification-feedback-loop/specs/code-review-simplification-feedback/spec.md (1)
1-1: LGTM!openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/bundle-overview-pages/spec.md (1)
3-3: LGTM!openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-docs-command-validation/spec.md (1)
3-3: LGTM!openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-docs-publishing/spec.md (1)
3-3: LGTM!openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/modules-pre-commit-quality-parity/spec.md (1)
3-3: LGTM!openspec/changes/archive/2026-06-06-docs-15-code-review-validation-guardrails/specs/review-run-command/spec.md (1)
3-3: LGTM!openspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/backlog-delta/spec.md (1)
1-1: LGTM!openspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/code-review-tool-dependencies/spec.md (1)
1-1: LGTM!openspec/changes/archive/2026-06-06-tester-module-cli-reliability/specs/modules-docs-command-validation/spec.md (1)
1-1: LGTM!openspec/specs/ci-integration/spec.md (1)
73-73: LGTM!openspec/specs/ci-module-signing-on-approval/spec.md (1)
54-54: LGTM!Also applies to: 73-73
openspec/specs/modules-docs-publishing/spec.md (1)
52-67: LGTM!openspec/specs/modules-pre-commit-quality-parity/spec.md (2)
28-43: LGTM!
44-53: LGTM!openspec/specs/bundle-packaged-resources/spec.md (1)
6-21: LGTM!openspec/specs/resource-aware-integrity/spec.md (3)
6-8: LGTM!
10-14: LGTM!
15-25: LGTM!openspec/changes/validation-02-full-chain-engine/design.md (2)
3-3: LGTM!Also applies to: 8-8, 15-15
39-39: Alignvalidation-02-full-chain-engineprerequisites with specfact-cli (dependency summary correctness).In
openspec/changes/validation-02-full-chain-engine/design.md(dependency summary at line 39), the prerequisites includegovernance-01-evidence-output,traceability-01-index-and-orphans, andpolicy-02-packs-and-modes. Innold-ai/specfact-cli, the first two appear inopenspec/CHANGE_ORDER.md, butpolicy-02-packs-and-modeshas references without a correspondingCHANGE_ORDERentry (and noopenspec/changes/policy-02-packs-and-modesdirectory found). Ensure this prerequisite is truly implemented/accepted in specfact-cli (or update the dependency summary/CHANGE_ORDER linkage accordingly).openspec/changes/validation-02-full-chain-engine/proposal.md (2)
1-1: LGTM!Also applies to: 13-18, 22-29, 35-40
49-49: Confirmnold-ai/specfact-cli#241core counterpart alignment for validation-02
#241exists (OPEN) and its scope matches the modules proposal: it keeps Req → Arch → Spec → Code → Tests as the only chain layers, adds optional--with-code-quality, and passescode_qualityinto the “governance evidence envelope” tied to the “traceability graph” framing (even though the issue title still says “Full-Chain Validation Engine”).openspec/changes/validation-02-full-chain-engine/tasks.md (1)
5-9: LGTM!Also applies to: 22-22
openspec/specs/review-finding-model/spec.md (1)
3-176: LGTM!openspec/specs/code-review-ai-bloat-detection/spec.md (1)
1-11: LGTM!Also applies to: 14-106
openspec/specs/clean-code-analysis/spec.md (1)
21-36: LGTM!openspec/specs/code-review-simplification-feedback/spec.md (1)
1-12: LGTM!Also applies to: 14-82
openspec/specs/guided-simplification-review/spec.md (1)
1-20: LGTM!Also applies to: 22-68
openspec/specs/cleanup-forecast-review/spec.md (1)
1-44: LGTM!openspec/specs/module-cli-error-contract/spec.md (1)
1-47: LGTM!openspec/specs/review-run-command/spec.md (1)
188-211: LGTM!openspec/specs/code-review-tool-dependencies/spec.md (1)
71-88: LGTM!openspec/specs/prompt-command-validation/spec.md (1)
31-48: LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note: the code-review wrapper skipped because this is an OpenSpec/docs-only change with no staged Python targets.
Governance Notes
Project-board metadata still needs recheck with a token that has project-field access before scoped implementation starts.