fix: replace stale flat command references and guard llms.txt freshness#607
Conversation
- Update runtime error suggestions from removed flat commands to canonical grouped commands (specfact code analyze contracts, specfact code repro, specfact project sync bridge, specfact govern enforce sdd). - Update validate_prompts CLI command map for grouped commands; plan verbs stay legacy until nold-ai/specfact-cli-modules#317 rehomes them. - Fix export-change-to-github docstrings to specfact project sync bridge. - Add tests/unit/docs/test_llms_overview_freshness.py re-running the command overview generator in --check mode so stale llms.txt or generated command references fail the suite even when the path-scoped pre-commit gate is bypassed (merge commits, --no-verify, bot commits). - Ignore local-only agent skills so repo lint gates skip them. - Bump version artifacts to 0.47.7 with changelog entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Strix is installed on this repository, but we could not run this PR security review because this workspace does not have an active plan. If you'd like to continue receiving code reviews, you can add a payment method or manage billing here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
🧰 Additional context used🔀 Multi-repo context nold-ai/specfact-cli-modulesnold-ai/specfact-cli-modules
Implication: The specfact-cli PR’s changes (suggestion strings, prompt-command mapping, and the new freshness test) are directly relevant to this modules repo because it is the source/consumer of llms.txt and generated command references; tests and docs here contain both legacy flat commands and canonical grouped commands that the PR updates aim to reconcile. [::nold-ai/specfact-cli-modules::] 📝 WalkthroughUser-Visible Behavior & CLI SurfaceThe PR updates CLI command references across documentation and error messaging to use grouped canonical commands (from the "flat" deprecated forms):
These changes affect:
Plan verb references remain intentionally on the legacy surface until tracked rehome (nold-ai/specfact-cli-modules#317). Contract & API ImpactNo changes to public function signatures, Pydantic models, or module boundaries. The prompt validator's Testing & Quality GatesNew freshness test suite (
The test includes helper functions Version & Changelog
Validation: New freshness test passed locally against sibling modules checkout; WalkthroughThis release bumps the package version to 0.47.7 and refactors CLI command references across suggestion helpers, documentation, and validation tools to use a reorganized command hierarchy. A new freshness test validates that generated command documentation remains in sync. ChangesVersion 0.47.7 Release
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
SpecFact CLI Validation Report✅ All validations passed! |
SpecFact CLI Validation Report✅ All validations passed! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edd6eb2e21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The generator resolves the companion modules checkout via SPECFACT_MODULES_REPO, a direct sibling, or the paired specfact-cli-worktrees layout; the freshness test's skip helper only checked the first two, so it skipped in paired-worktree checkouts where it could run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
SpecFact CLI Validation Report✅ All validations passed! |
Summary
specfact analyze/specfact repro→specfact code analyze contracts/specfact code repro), prompt validator command map (specfact enforce sdd/specfact sync bridge→ grouped forms), and export-change-to-github docstringstests/unit/docs/test_llms_overview_freshness.py: re-runs the command overview generator in--checkmode so a stalellms.txtor generated command reference fails the test suite even when the path-scoped pre-commit gate is bypassed (merge commits,--no-verify, bot commits); skips when the companion modules checkout is unavailable.agents/skills/so repo lint gates skip themA companion freshness test lands in specfact-cli-modules (its CI skips overview validation on dev-to-main promote runs — the bigger gap).
Validation
🤖 Generated with Claude Code