Skip to content

Corrected area: Updates in get_jv_archive#101

Open
paolog8 wants to merge 8 commits into
mainfrom
99-add-corrected-area-to-jv-measurements
Open

Corrected area: Updates in get_jv_archive#101
paolog8 wants to merge 8 commits into
mainfrom
99-add-corrected-area-to-jv-measurements

Conversation

@paolog8

@paolog8 paolog8 commented Jun 26, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@paolog8 paolog8 linked an issue Jun 26, 2025 that may be closed by this pull request
Comment thread src/baseclasses/solar_energy/jvmeasurement.py Outdated
@paolog8 paolog8 requested a review from RoteKekse June 26, 2025 14:18
@paolog8 paolog8 marked this pull request as ready for review June 26, 2025 15:19

@RoteKekse RoteKekse left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add a test
  2. in the schema for jvm there is a calculation for the solar cell parameters, for the sake of minimal changes can you check if this can be used?

@paolog8 paolog8 changed the title 99 add corrected area to jv measurements Corrected area: Updates in get_jv_archive Jul 2, 2025
@RoteKekse RoteKekse force-pushed the 99-add-corrected-area-to-jv-measurements branch from 527aaa4 to cabdc1c Compare July 25, 2025 12:31
@RoteKekse RoteKekse force-pushed the 99-add-corrected-area-to-jv-measurements branch from 0fdc3b7 to cee4fe6 Compare August 19, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "corrected area" to JV measurements

2 participants