Refactor user show view to display API tokens conditionally and remov…#168
Open
fujiwara-e wants to merge 3 commits intonomlab:mainfrom
Open
Refactor user show view to display API tokens conditionally and remov…#168fujiwara-e wants to merge 3 commits intonomlab:mainfrom
fujiwara-e wants to merge 3 commits intonomlab:mainfrom
Conversation
…e links for user name and screen name
There was a problem hiding this comment.
Pull request overview
Fixes a data-leak issue where a logged-in user’s API token(s) could appear on another user’s detail page.
Changes:
- Restricts
UsersController#showto load API tokens only when the shown user is the current user. - Updates the user show view to render the API token section only for the current user.
- Removes self-referential links from the name and screen name fields on the user show page.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| app/controllers/users_controller.rb | Conditionally loads @api_tokens only for the current user to prevent cross-user exposure. |
| app/views/users/show.html.erb | Conditionally renders the API token section only when viewing your own profile; adjusts name/screen name display. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ユーザ詳細画面で,ログインしていないユーザの画面にログインしているユーザの API キーが表示されるようになっていた.
変更点
UsersControllerで表示中のユーザがログインユーザと同じ場合のみトークンを取得.