Fix warnings about incorrect prototypes & use standard memcpy/memset#7
Open
hhoffstaette wants to merge 1 commit intonondeterministic:masterfrom
Open
Fix warnings about incorrect prototypes & use standard memcpy/memset#7hhoffstaette wants to merge 1 commit intonondeterministic:masterfrom
hhoffstaette wants to merge 1 commit intonondeterministic:masterfrom
Conversation
Clang-15 rightfully complains about function definitions without proper prototypes. Also replace handrolled memcpy/memset with standard C library calls. Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Contributor
Author
|
In case you're wondering: I didn't even know it was possible to define functions this way.. ¯\_(ツ)_/¯ |
Contributor
Author
|
Btw I'm running this change on my server and it seems to work fine so far - just to make sure I didn't break anything. I mean..handrolled memcpy.. 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang-15 rightfully complains about function definitions without proper prototypes. Also replace handrolled memcpy/memset with standard C library calls.
Signed-off-by: Holger Hoffstätte holger@applied-asynchrony.com