docs: clarify NIP-66 methodology, data sourcing, and known gaps#46
docs: clarify NIP-66 methodology, data sourcing, and known gaps#46alltheseas wants to merge 2 commits intomainfrom
Conversation
Address documentation gaps surfaced by developer feedback on the NIP-66 PR. Adds FAQ-style subsections to the implementation guide covering data sourcing (events vs HTTP), provider independence, Tor/.onion handling (including the clearnet-monitor-vs-Tor-path gap), safety guardrails, and liveness/strict mode differences. Adds NIP-66 A/B comparison methodology to the benchmark recreation guide. Clarifies benchmark context in README. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds comprehensive documentation about NIP-66 liveness comparison and pre-filtering across three documentation files, detailing the --nip66-filter flag, two filtering modes (strict and liveness), data sources, usage examples, and implementation considerations. No functional code changes are included. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dead relays are dead regardless of network path. Tor-default clients (e.g. Amethyst) benefit MORE from NIP-66 filtering because Tor timeouts are 2-3x longer — eliminating dead relays before connection avoids 30-90s Tor-routed timeouts to servers that will never respond. Replaces incorrect "skip NIP-66 in Tor mode" advice with "apply unconditionally; use local health tracking for the Tor-exit-blocking blind spot." Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
Addresses documentation gaps surfaced by developer feedback on the NIP-66 relay liveness filtering recommendation. Developers reading the existing docs couldn't answer basic questions about the approach — this PR closes those gaps.
Gaps closed
30166events vs HTTP API,strictvslivenessmodes, and how production integrations (NDK, Applesauce) differ from the benchmark tool30166is a replaceable event any monitor can publish.onionURLs (already preserved) and clearnet relays accessed through Tor (known gap — liveness data reflects clearnet path, not Tor exit-node reachability)run-nip66-comparison.shinstructionsFiles changed
IMPLEMENTATION-GUIDE.md— FAQ-style subsections under the existing NIP-66 sectionBenchmark-recreation.md— NIP-66 liveness comparison methodology subsectionREADME.md— one-line benchmark context clarificationTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes