Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes 1,517 lines of legacy fastify-based code that is no longer used after the migration to JavaScriptSolidServer (jspod). The current implementation in index.js is a lightweight wrapper around jspod and does not depend on any of the removed files.
Changes:
- Removed legacy fastify-based relay implementation and supporting infrastructure
- Removed old tests for legacy code
- Removed old deployment and admin tools
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| index.js.legacy | Removed 429 lines of old fastify-based relay implementation with DID endpoints and WebSocket support |
| bin/relay.js | Removed 23 lines of legacy CLI entry point that used the old createServer function |
| lib/did-endpoint.js | Removed 128 lines of DID document generator library used by legacy code |
| test/integration-test.js | Removed 161 lines of integration tests for legacy DID endpoint functionality |
| test/did-endpoint.test.js | Removed 194 lines of unit tests for DID endpoint library |
| test/cors-test.js | Removed 113 lines of CORS testing script for legacy endpoints |
| test/cors-test.html | Removed 176 lines of browser-based CORS testing interface |
| admin.html | Removed 198 lines of legacy admin interface for monitoring relay |
| deploy.sh | Removed 95 lines of VPS deployment script for legacy version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #28 Removes unused code from old fastify architecture: - index.js.legacy (old relay) - bin/ (old CLI) - lib/ (old DID endpoint - not used by jspod) - test/ (tests for old code) - deploy.sh (old deploy script) Keeps admin.html (relay testing tool) with updated URL for jspod: - Changed ws://localhost:4444 to ws://localhost:4444/relay
melvincarvalho
force-pushed
the
remove-legacy-code
branch
from
7a0ae06 to
c193fc2
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 1,517 lines of dead code from the old fastify-based architecture.
Fixes #28
Removed files
index.js.legacy- old fastify relaybin/relay.js- old CLI entry pointlib/did-endpoint.js- old DID endpointtest/- tests for old code (4 files)admin.html- old admin interfacedeploy.sh- old deploy scriptKept
MIGRATION.md- documents the transition for referenceTest plan
npx fonstrstill works (only uses index.js + jspod)