add upwardPreference and downwardPreference in PullDownMenuPosition.#68
Open
parcool wants to merge 2 commits into
Open
add upwardPreference and downwardPreference in PullDownMenuPosition.#68parcool wants to merge 2 commits into
parcool wants to merge 2 commits into
Conversation
Owner
|
Hey @parcool, Thanks for the PR. I'm sorry it took a long time for me to respond. I've noticed a few issues with the current implementation. The menu is not shown when using The menu clips it's size when using You can verify this behavior by running the example app -> examples -> I have not looked at the code yet, so I am not sure what the problem is with both added options. |
Owner
|
Hi @parcool, just checking in, are you still interested in landing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


When the button is in the lower half of the screen and there's sufficient space below it to display the popup menu, use [downwardPreference] to position the menu below the button. The same logic applies to [upwardPreference].