Fix panic if all players but one fold preflop#6
Open
alcamerone wants to merge 1 commit intonotnil:masterfrom
Open
Fix panic if all players but one fold preflop#6alcamerone wants to merge 1 commit intonotnil:masterfrom
alcamerone wants to merge 1 commit intonotnil:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for publishing this library, I was impressed by how comprehensive it is!
I found a bug where, if all the players fold pre-flop but one, it panics as the the players' hands are not big enough without any table cards for comparisons in the payout. I solved this by checking if the number of players contesting the pot is greater than one, and, if not, simply awarding the pot to the only contestant. Please see the test case I added as well.
Hope this is helpful, thanks again!