Conversation
Owner
Author
|
blarg, |
Owner
Author
|
other options look equally bad. this will work. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new copy subcommand for copying logs to the clipboard and updates the environment/tooling to Go 1.24.
- Adds a
copyCLI command using thegolang.design/x/clipboardpackage - Bumps Go versions across
go.mod,shell.nix, and CI workflows to 1.24 and installs necessary system deps - Refactors task definitions in
tasks.tomland updates the README with Linux build notes
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tasks.toml | Flattened multi-line cmds arrays and added a new:command task |
| shell.nix | Updated Go to 1.24, added nativeBuildInputs and X11 in buildInputs |
| go.mod | Upgraded Go to 1.24, added golang.design/x/clipboard dependency |
| cmd/copy.go | Implemented the new copy command |
| README.md | Revised source install section and noted X11 header requirement |
| .github/workflows/test.yml | Updated Go version, installed X11 headers |
| .github/workflows/release.yml | Updated Go version, installed X11 headers |
Comments suppressed due to low confidence (4)
cmd/copy.go:36
- [nitpick] The function name "copy" shadows the built-in Go function and is ambiguous; consider renaming it to "copyToClipboard" for clarity.
func copy(content []byte) error {
.github/workflows/test.yml:15
- The CI step installs only X11 headers but misses required build tools (gcc and pkg-config) needed for the clipboard dependency; add them to the apt-get install command.
- run: sudo apt-get install libx11-dev
.github/workflows/release.yml:23
- Similar to the test workflow, this step should also install gcc and pkg-config alongside libx11-dev to ensure successful builds with the clipboard package.
- run: sudo apt-get install libx11-dev
go.mod:41
- [nitpick] This indirect dependency appears to be pulled in transitively; consider removing explicit require lines for indirect modules and letting 'go mod tidy' handle them.
golang.org/x/exp/shiny v0.0.0-20250606033433-dcc06ee1d476 // indirect
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a
copysubcommand that copies the specified log to the clipboard.supports all the same log selection stuff.
daylog copycopies today's log,similarly, logs from past/future work too,
daylog copy -- tomorrow,closes #48
also bumps go to 1.24