Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the explicit CGO_ENABLED=0 setting so that cgo-dependent functionality (e.g., clipboard) works on macOS, and adds the binary field to name the output artifact.
- Drop
CGO_ENABLED=0to enable cgo support for clipboard operations - Add
binary: daylogto specify the output binary name in Goreleaser
Comments suppressed due to low confidence (2)
.goreleaser.yaml:8
- [nitpick] Removing the CGO_DISABLED flag globally may lead to cross-compilation issues on non-macOS hosts. Consider splitting the build into separate entries or using conditional env interpolation so only the macOS build enables CGO.
- - CGO_ENABLED=0
.goreleaser.yaml:11
- [nitpick] It may help future maintainers to add a brief comment above
binary: daylogexplaining that this field sets the output artifact name.
binary: daylog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
local builds worked but the goreleaser builds didn't work for me on macos,