Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the charmbracelet/fang library to handle CLI execution, version output, and manpage generation, while updating related dependencies.
- Remove custom
versioncommand in favor of fang’s built-in version handling - Bump
cobrato v1.9.1 and addfangplus its indirect dependencies ingo.mod - Replace
rootCmd.Execute()withfang.Execute()incmd/root.go
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Added charmbracelet/fang (v0.1.0), bumped cobra, and pulled in fang’s indirect modules |
| cmd/version.go | Removed vestigial custom version command |
| cmd/root.go | Switched CLI entrypoint to fang.Execute, imported context and fang |
| version, commit = v, c | ||
| err := rootCmd.Execute() | ||
|
|
||
| err := fang.Execute(context.TODO(), rootCmd, |
There was a problem hiding this comment.
[nitpick] Consider using context.Background() instead of context.TODO() for a clearer intent in production code.
Suggested change
| err := fang.Execute(context.TODO(), rootCmd, | |
| err := fang.Execute(context.Background(), rootCmd, |
|
|
||
| require ( | ||
| github.com/adrg/xdg v0.4.0 | ||
| github.com/charmbracelet/fang v0.1.0 |
There was a problem hiding this comment.
After pulling in new dependencies, run go mod tidy to clean up any unused modules and keep the dependency graph minimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fancy, shiny, closes #53