Skip to content

refactor: simplify page title logic and improve accessibility in App.vue#28

Open
poketonova wants to merge 1 commit into
mainfrom
dev-agent-improvement-2026-06-11
Open

refactor: simplify page title logic and improve accessibility in App.vue#28
poketonova wants to merge 1 commit into
mainfrom
dev-agent-improvement-2026-06-11

Conversation

@poketonova

Copy link
Copy Markdown
Collaborator

This pull request refactors the currentPageTitle computed property in App.vue to leverage the router's metadata.

Changes:

  • Simplified Title Logic: Instead of manually maintaining a mapping of route names to titles in App.vue, the code now primarily uses route.meta.title. This reduces code duplication and ensures that the UI title stays in sync with the document title defined in the router.
  • Improved Coverage: Added support for routes that were previously missing in the manual mapping, such as 'Decks', 'Meta Decks', and 'Deck Builder', which will now display their correct titles instead of the default 'Rarebox'.
  • Accessibility Fix: Removed aria-hidden="true" from the .topbar-page element. Since this element displays the current page title, it should be accessible to screen readers.
  • Code Cleanliness: Removed redundant if statements for static routes.

This automated improvement enhances maintainability and accessibility of the tactile shell.

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pokemon-collectr Error Error Jun 11, 2026 3:01pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant