Skip to content

Refactor: Simplify page title logic in App.vue#32

Open
poketonova wants to merge 1 commit into
mainfrom
dev-agent-improvement-2026-06-15
Open

Refactor: Simplify page title logic in App.vue#32
poketonova wants to merge 1 commit into
mainfrom
dev-agent-improvement-2026-06-15

Conversation

@poketonova

Copy link
Copy Markdown
Collaborator

This PR refactors the currentPageTitle computed property in App.vue to dynamically use the title defined in the route's meta object.

Improvements:

  1. Redundancy Reduction: Removes the manual mapping of route names to titles, leveraging the already existing titles in the router configuration.
  2. Bug Fix: Resolves issues where several pages (like Decks, Meta Decks, and Deck Builder) were falling back to the default "Rarebox" title because they weren't explicitly handled in the if chain.
  3. Maintainability: New routes added to the application will now automatically have their titles displayed in the mobile top bar as long as a meta.title is provided in the router.
  4. Consistency: Ensures the title shown in the app UI matches the document.title set during navigation.

The special logic for displaying the active portfolio name remains intact.

@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pokemon-collectr Ready Ready Preview, Comment Jun 15, 2026 3:02pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant