Refactor: Consolidate load indicator logic and improve theme utils#42
Open
poketonova wants to merge 1 commit into
Open
Refactor: Consolidate load indicator logic and improve theme utils#42poketonova wants to merge 1 commit into
poketonova wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automated contribution focuses on code quality and internal consistency:
CardLoadIndicator.vue: Consolidates the loading speed calculation by reusing thespeedcomputed property within thetimeLeftlogic. This reduces redundancy and ensures that time estimates are consistent across different parts of the UI.theme.js: Adds anisLight()helper function to complement the existingisDark(). This improves developer ergonomics and provides a more complete API for theme-related logic.These changes are small, safe, and improve the maintainability of the codebase.