feat: improve PriceCharting service reliability and error handling#43
Open
poketonova wants to merge 1 commit into
Open
feat: improve PriceCharting service reliability and error handling#43poketonova wants to merge 1 commit into
poketonova wants to merge 1 commit into
Conversation
- Added AbortSignal.timeout to fetch calls to prevent hanging requests. - Added consistent try-catch blocks for network/CORS errors in both search and product details. - Standardized error reporting for better UI feedback.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pro Value Contribution
This automated PR improves the reliability and consistency of the
PriceChartingservice in Rarebox.Key Improvements:
AbortSignal.timeout(10s) into API calls. This prevents the app from waiting indefinitely on hanging network requests, ensuring a snappier user experience even on poor connections.try-catchwrapper togetPCProduct, bringing it in line withsearchPCProducts. Both methods now consistently catch CORS, network, and timeout errors, providing predictable error signals to the UI.This change aligns the PriceCharting service with the robust error-handling patterns found in other parts of the codebase (like
pokemonApi.js).