Skip to content

Refactor: Dynamic page titles from route meta#46

Open
poketonova wants to merge 1 commit into
mainfrom
dev-agent-refactor-title-2026-07-03
Open

Refactor: Dynamic page titles from route meta#46
poketonova wants to merge 1 commit into
mainfrom
dev-agent-refactor-title-2026-07-03

Conversation

@poketonova

Copy link
Copy Markdown
Collaborator

This PR refactors the currentPageTitle computed property in App.vue to dynamically use the title defined in the route's meta object.

Pro value

  1. DRY (Don't Repeat Yourself): Removes a long list of manual route-to-title mappings that were already defined in the router configuration.
  2. Maintenance: New pages with a meta.title in src/router/index.js will now automatically display the correct title in the top bar without needing additional code in App.vue.
  3. Consistency: Fixes missing titles for several routes (like Deck Builder and Meta Decks) that previously defaulted to 'Rarebox' despite having titles defined in the router.
  4. Readability: Simplifies the component logic, making it easier for future contributors to understand how titles are managed.

This automated contribution improves code quality and extensibility with zero risk to existing functionality.

@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pokemon-collectr Error Error Jul 3, 2026 3:02pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant