refactor: improve navigation tab mapping and page title logic#48
Open
poketonova wants to merge 1 commit into
Open
refactor: improve navigation tab mapping and page title logic#48poketonova wants to merge 1 commit into
poketonova wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automated PR improves the navigation and title logic in
App.vue:currentPageTitle: Instead of manually mapping route names to titles (which was incomplete and redundant), it now usesroute.meta.titlefrom the router configuration as the default source. Special handling remains for dynamic portfolio names.TAB_FOR_ROUTE: Missing routes (likeMetaDecks,BoothDisplay,Settings, etc.) are now correctly mapped to their respective navigation tabs, ensuring the active state is preserved during deep navigation.Pro Value: This change reduces manual maintenance overhead for new routes and ensures a more consistent UI state across the application's expanding feature set.