Fix incorrect minimum heigh check in multiline#88
Open
whisperchan wants to merge 1 commit intonpcole:masterfrom
Open
Fix incorrect minimum heigh check in multiline#88whisperchan wants to merge 1 commit intonpcole:masterfrom
whisperchan wants to merge 1 commit intonpcole:masterfrom
Conversation
The minimum height check by default assumes a contained widget height of 1 line. Because it requires space for at least two containing widgets this is set to 2. Setting this internal should not be required by inheriting classes. Instead the check should use the _contained_widget_height property. Currently having contained widgets with a height > 1 and two or more values with less than two times the space available will cause an infinite recursion loop.
Author
|
I've been looking at MultiLine after someone reported a bug in my application to me. Therefor the requirement to the height should be: Space for one contained widget and the more label. But currently the code assumes, I think, there are at least two widgets (one being the more label). Thus I changed the check to two times the size of the contained widget. Rewriting it to one contained_widget + more_label would be the better (but more expensive) thing to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum height check by default assumes a
contained widget height of 1 line. Because it requires space for
at least two containing widgets this is set to 2.
Setting this internal should not be required by inheriting classes.
Instead the check should use the _contained_widget_height property.
Currently having contained widgets with a height > 1 and two or more values with
less than two times the space available will cause an infinite recursion loop.