fix(stage): strip path separators from staged tarball filename#9721
Open
ubeddulla wants to merge 1 commit into
Open
fix(stage): strip path separators from staged tarball filename#9721ubeddulla wants to merge 1 commit into
ubeddulla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm stage downloadbuilds the output filename from the staged tarball's own package.json name and version, but those come straight out of the untrusted tarball (parsed raw, never validated), and the name only replaces the first@//while the version is dropped in verbatim. A staged package whose version is something like../../../../tmp/pwnedmakesresolve(process.cwd(), filename)walk out of the working directory, sowriteFiledrops the attacker-controlled bytes at an arbitrary path. Strip every separator from the name and version before building the filename, the same way libnpmpack does, so it stays a single component inside cwd. Added a regression test that downloads a tarball with a crafted version and checks nothing lands outside the cwd.