-
-
Notifications
You must be signed in to change notification settings - Fork 140
fix: local execute for yarn v1 and 2+ compatibility #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
wojtekmaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes without proper investigation may look like an error at first glance. I'd sprinkle it with some inline comments if I were you.
|
I think it's common enough to treat yarn v1 and yarn "berry" v2+ as effectively two different package managers. We could just have them be separate options. Or not support v1... and technically for yarn v1 we could use |
|
I mean yeah but for the sake of what? It is important for devs to have install commands crafted specially for their package manager, but for one-time command no one could possibly care. I'd just scrap the whole thing and just hardcode this to npx command for every package manager :D |
|
|
For when we publish
npmx-connectortonpmenable package manager preferences, this will make the command foryarnpackage manager becomenpx npmx-connector.It also means
npxwill be used anywhereyarnlocal execution is accessed. Which I think is fine. Interestingly, "execute remote" is currently set to yarn dlx still, which is only supported by Yarn 2+.I might get shade for saying it, but we may want to consider only supporting Yarn 2+ and dropping Yarn 1 users given how old and outdated it is and so many better alternatives around. Just my two cents. As-is the current UI doesn't really support v1 of yarn, since
dlxis not an option.Closes #515