Skip to content

Conversation

@wojtekmaj
Copy link
Contributor

Zrzut ekranu_31-1-2026_233157_localhost

Copilot AI review requested due to automatic review settings January 31, 2026 22:32
@vercel vercel bot temporarily deployed to Preview – docs.npmx.dev January 31, 2026 22:32 Inactive
@vercel
Copy link

vercel bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 1, 2026 0:23am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 1, 2026 0:23am
npmx-lunaria Ignored Ignored Feb 1, 2026 0:23am

Request Review

@github-actions
Copy link

github-actions bot commented Jan 31, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
lunaria/files/pl-PL.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds i18n support for the compare page by moving facet labels/descriptions (and some value strings) into locale dictionaries and wiring translation into the compare UI + comparison composable.

Changes:

  • Replaced hardcoded facet labels/descriptions with i18n keys (via getFacetLabelKey / getFacetDescriptionKey).
  • Added compare facet items + values translations to locale JSON files (en/pl).
  • Updated usePackageComparison to accept an i18n translate function for value display strings.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/nuxt/components/compare/FacetSelector.spec.ts Updates assertions to account for translated facet labels.
shared/types/comparison.ts Removes hardcoded label/description fields and adds i18n key helpers for facets.
app/pages/compare.vue Uses i18n for facet labels/descriptions and passes t into usePackageComparison.
app/composables/usePackageComparison.ts Translates certain computed facet value display strings via injected t.
app/components/compare/FacetSelector.vue Uses i18n keys for button labels, aria-labels, and descriptions/tooltips.
i18n/locales/en.json Adds compare facet items and values translation entries.
i18n/locales/en-US.json Adds compare facet items and values translation entries (currently duplicates en.json).
i18n/locales/pl-PL.json Adds Polish compare facet items and values translation entries.
lunaria/files/en-US.json Adds compare facet items and values entries for Lunaria source locale.
lunaria/files/pl-PL.json Adds Polish compare facet items and values entries for Lunaria.

@trueberryless
Copy link
Contributor

Personally, I think translations should always be done in separate PRs to keep the scope clean. But since it's already here, I don't see a reason to remove them again (just for the future) 😉

@wojtekmaj
Copy link
Contributor Author

Personally, I think translations should always be done in separate PRs to keep the scope clean. But since it's already here, I don't see a reason to remove them again (just for the future) 😉

I fully get that - I was kind of forced to write at least one translation to be able to even see if I didn't miss anything though! That was a tough one to i18n!

@trueberryless
Copy link
Contributor

I fully get that - I was kind of forced to write at least one translation to be able to even see if I didn't miss anything though! That was a tough one to i18n!

Ah, that's a valid reason actually. Then it's very beneficial to be multilingual 😅 Bravo 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants