-
-
Notifications
You must be signed in to change notification settings - Fork 139
refactor: remove class shortcuts #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: remove class shortcuts #604
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
This was changed in npmx-dev#587
garthdw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
can I ask what the motivation is for this? does it improve performance or reduce the amount of emitted css or markup? |
…-shortcuts # Conflicts: # app/pages/[...package].vue
|
@danielroe This relates to your answer to my question Main benefits:
Currently I found it a bit hard to figure out, where some styles where coming from, and simplifying the ways components can be styled across the code base would improve DX imho. Like I said in the initial PR message: This isn't a complete change, there are some other shortcuts, that can also be moved into components, but I wanted to get the easy ones out of the way and would open individual PRs for the more complex cases. Should the mixture of atomic utility classes and shortcuts be a deliberate design decision, this PR can probably be closed. |
This remove a few unnecessary UnoCSS shortcuts as follows:
Cardcomponent and removecardandcard-interactiveshortcutSkeletonInlineandSkeletonBlockcomponents and removeskeletonshortcutcode-blockinput-basedividersectionThere are some more Uno shortcuts that can be removed, but they need a little more care and probably their own PR. Those were the easy wins.