-
-
Notifications
You must be signed in to change notification settings - Fork 139
fix: configure general rule for trailing slash #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
43081j
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does work, so seems like a good change to me
to get it to work in dev, we'd need to configure nuxt's router.options.strict to false i think, but that seems to break other things. so for now, maybe we just don't bother in dev and figure it out in a separate PR
|
this is good we can also add a global route middleware, dev only, which redirects |
|
@danielroe |
|
it'll be more performant to do the cdn-level redirect as opposed to middleware |
|
Done |
Trailing slash setup. For example I often visit a page with a slash in the end and see a 404 error, even though the package exists. Now it will redirect.
I did this using vercel config. I'm a little concerned that this approach won't work during local development, but it seems better than leaving things as they are. Any better ideas would be appreciated [if needed]
Closes #648