-
-
Notifications
You must be signed in to change notification settings - Fork 146
test: move nuxt unit tests to test/nuxt
#676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
We need this to resolve types correctly amongst other things.
f881ea7 to
f2378be
Compare
| provider: 'stackblitz', | ||
| providerName: 'StackBlitz', | ||
| label: 'Demo on StackBlitz', | ||
| url: 'https://stackblitz.com/github/user/repo', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests for server utilities should not be in test/nuxt - test nuxt emulates the browser and will not work with server utils
|
sad times, @danielroe any idea what we should do here:
its a commonjs dependency, with an export assignment this must work at runtime since we bundle everything, so why not in tests? 🤔 |
|
it's not bundled by nuxt - the server files are bundled by nitro and run in a different context test/nuxt is a special dir and shouldn't be used for testing anything in server/ |
|
we can merge this one and ill do the type check setup in a follow up pr |
We need this to resolve types correctly amongst other things.