Skip to content

Conversation

@43081j
Copy link
Collaborator

@43081j 43081j commented Feb 1, 2026

We need this to resolve types correctly amongst other things.

@vercel
Copy link

vercel bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 2, 2026 0:11am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 2, 2026 0:11am
npmx-lunaria Ignored Ignored Feb 2, 2026 0:11am

Request Review

We need this to resolve types correctly amongst other things.
provider: 'stackblitz',
providerName: 'StackBlitz',
label: 'Demo on StackBlitz',
url: 'https://stackblitz.com/github/user/repo',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests for server utilities should not be in test/nuxt - test nuxt emulates the browser and will not work with server utils

@43081j
Copy link
Collaborator Author

43081j commented Feb 1, 2026

sad times, @danielroe any idea what we should do here:

Caused by: SyntaxError: The requested module '/node_modules/.pnpm/sanitize-html@2.17.0/node_modules/sanitize-html/index.js?v=4f273e36' does not provide an export named 'default'

its a commonjs dependency, with an export assignment

this must work at runtime since we bundle everything, so why not in tests? 🤔

@danielroe
Copy link
Member

it's not bundled by nuxt - the server files are bundled by nitro and run in a different context

test/nuxt is a special dir and shouldn't be used for testing anything in server/

@43081j
Copy link
Collaborator Author

43081j commented Feb 2, 2026

we can merge this one and ill do the type check setup in a follow up pr

@danielroe danielroe added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit f824e77 Feb 2, 2026
16 checks passed
@danielroe danielroe deleted the jg/test-reorg-nuxtify branch February 2, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants