Conversation
📝 WalkthroughWalkthroughThis PR moves hover handling from the VS Code extension into the language server: it removes the extension-side hover provider and its tests, adds a hover plugin in the language-service package, updates the language-server and workspace APIs (nearest-package-manifest lookup and dependency-resolution-by-containing-package), adjusts language-core import/offset utilities, and changes the VS Code client to wrap hover results into MarkdownString with HTML enabled. It also wires the Volar language server into extension activation and enables copying server build artifacts into the extension distribution. Possibly related PRs
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e91adfcb-6835-4e44-80bb-b892707e71dd
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (17)
extensions/vscode/src/client.tsextensions/vscode/src/index.tsextensions/vscode/src/providers/hover/index.tsextensions/vscode/src/providers/hover/npmx.tsextensions/vscode/src/providers/hover/resolve.test.tsextensions/vscode/src/providers/hover/resolve.tsextensions/vscode/tsdown.config.tspackages/language-core/src/utils/source-import.test.tspackages/language-core/src/utils/source-import.tspackages/language-core/src/workspace.tspackages/language-server/src/workspace.tspackages/language-service/package.jsonpackages/language-service/src/index.tspackages/language-service/src/plugins/hover.tspackages/language-service/src/types.tspackages/language-service/src/utils/range.tsplayground/index.ts
💤 Files with no reviewable changes (4)
- extensions/vscode/src/providers/hover/index.ts
- extensions/vscode/src/providers/hover/npmx.ts
- extensions/vscode/src/providers/hover/resolve.test.ts
- extensions/vscode/src/providers/hover/resolve.ts
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 51ce2289-f206-4f2d-9823-918584c0a0ed
📒 Files selected for processing (2)
packages/language-core/src/utils/source-import.test.tspackages/language-core/src/utils/source-import.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/language-core/src/utils/source-import.ts
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 32665f15-3e69-4b44-a68f-c547f27c1935
📒 Files selected for processing (3)
extensions/vscode/src/client.tspackages/language-core/src/utils/source-import.test.tspackages/language-core/src/utils/source-import.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/language-core/src/utils/source-import.test.ts
- extensions/vscode/src/client.ts
No description provided.