Add Rate Limiting Middleware#237
Open
spjmurray wants to merge 1 commit into
Open
Conversation
spjmurray
force-pushed
the
rate_limiting
branch
from
27e6c42 to
8845639
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 28.45% 28.56% +0.10%
==========================================
Files 72 74 +2
Lines 3795 3858 +63
==========================================
+ Hits 1080 1102 +22
- Misses 2615 2656 +41
Partials 100 100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Based on the ubiquitous leaky bucket algorithm, this version does synchronous leaks and is non-blocking. The middleware packages this all up into something that initially does global and per-endpoint rate limits.
spjmurray
force-pushed
the
rate_limiting
branch
from
8845639 to
8eb7830
Compare
squaremo
reviewed
Jan 23, 2026
| // via a leak at a fixed period that is defined by the requests per second. If the | ||
| // bucket ever becomes full, then requests are rejected with a 429. This algorithm | ||
| // allows for bursty workloads. | ||
| // NOTE: Uber do have an implmentation, but it's blocking. Where as this fails |
Contributor
There was a problem hiding this comment.
The usual one is https://pkg.go.dev/golang.org/x/time/rate#Limiter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the ubiquitous leaky bucket algorithm, this version does synchronous leaks and is non-blocking. The middleware packages this all up into something that initially does global and per-endpoint rate limits.